Conversation
This was referenced Oct 22, 2024
c9cf13f to
27825d8
Compare
aa212ae to
e673e74
Compare
closes #6640 Could you suggest how I should test it? (already tested locally) --------- Co-authored-by: konstin <konstin@mailbox.org> Co-authored-by: Charles Tapley Hoyt <cthoyt@gmail.com> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
Migrate all directory related logic to `etcetera`, eliminated two dependecies.
…the installer (#8420) Reviving #2236 Basically implements axodotdev/cargo-dist#287
These settings can only be defined in `pyproject.toml`, since they're project-centric, and not _configuration_. Closes #8539. --------- Co-authored-by: Zanie Blue <contact@zanie.dev> Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com> Co-authored-by: konsti <konstin@mailbox.org>
See extensive discussion in #8433 (comment). This PR brings us into alignment with the standard library by using `sys._base_executable` rather than canonicalizing the executable path. The benefits are primarily for Homebrew, where we'll now resolve to paths like `/opt/homebrew/opt/python@3.12/bin` instead of the undesirable `/opt/homebrew/Cellar/python@3.9/3.9.19_1/Frameworks/Python.framework/Versions/3.9/bin`. Most other users should see no change, though in some cases, nested virtual environments now have slightly different behavior -- namely, they _sometimes_ resolve to the virtual environment Python (at least for Homebrew; not for rtx or uv Pythons though). See [here](https://docs.google.com/spreadsheets/d/1Vw5ClYEjgrBJJhQiwa3cCenIA1GbcRyudYN9NwQaEcM/edit?gid=0#gid=0) for a breakdown. Closes #1640. Closes #1795.
Not verifying the certificates of certain hosts should be supported for all kinds of HTTPS connections, so we're making it a global option, just like native tls. This fixes the remaining places using a client but were not configuring allow insecure host. Fixes #6983 (i think) Closes #6983 --------- Co-authored-by: Charlie Marsh <charlie.r.marsh@gmail.com>
…6370) Uses #6369 for test coverage. Updates version file discovery to search up into parent directories. Also refactors Python request determination to avoid duplicating the user request / version file / workspace lookup logic in every command (this supersedes the work started in #6372). There is a bit of remaining work here, mostly around documentation. There are some edge-cases where we don't use the refactored request utility, like `uv build` — I'm not sure how I'm going to handle that yet as it needs a separate root directory.
Implement a full working version of local version semantics. The (AFAIA) major move towards this was implemented in #2430. This added support such that the version specifier `torch==2.1.0+cpu` would install `torch@2.1.0+cpu` and consider `torch@2.1.0+cpu` a valid way to satisfy the requirement `torch==2.1.0` in further dependency resolution. In this feature, we more fully support local version semantics. Namely, we now allow `torch==2.1.0` to install `torch@2.1.0+cpu` regardless of whether `torch@2.1.0` (no local tag) actually exists. We do this by adding an internal-only `Max` value to local versions that compare greater to all other local versions. Then we can translate `torch==2.1.0` into bounds: greater than 2.1.0 with no local tag and less than 2.1.0 with the `Max` local tag. Depends on astral-sh/packse#227.
After #8797, we have spec-compliant handling for local version identifiers and can completely remove all the special-casing around it.
See discussion in #8797.
We don't actually want users to see this, but we should be stripping it anyway. Without this change, we show ranges in the debug logs that look like `>=1.0.0, <1.0.0`, which is more confusing than helpful. (We may want to post-process those debug ranges to remove these.)
…bers if the version differs (#8897) We'll read these from the workspace root anyway!
Contributor
|
Should the |
Member
Author
|
Thanks for the reminder. I'll do that / migrate the unclosed issues. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Includes
!=operator is used #7974directoresanddirs-sys#8048.envand custom env files inuv run#8263.envfiles in--env-file#8463~/.local/bin) instead of the Cargo home directory in the installer #8420.python-versionfiles in parent directories #6370[max]local version intoVersionSmall#8843.python-versionfiles in projects even if one exists outside of it #8896.python-versionfiles duringuv initfor workspace members if the version differs #8897.python-versionfile discovery #8898