Chore/update enum translations#696
Open
wouter-athom wants to merge 3 commits into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates translation strings for multiple enum capabilities, primarily within $flow trigger/condition/action card titles, to make the phrasing more consistent (e.g., “changed to”, “set … to”) and to fix a few incorrect template markers / typos.
Changes:
- Standardizes many “*_changed” flow trigger titles to explicitly indicate a change “to” a selected mode/value.
- Updates several condition/action titles to use clearer wording (e.g., “Set the … mode to”, adding articles where appropriate).
- Fixes a few concrete translation issues (e.g., malformed template marker in
oven_mode, duplicated French text infan_mode, incorrect Danish placeholders).
Reviewed changes
Copilot reviewed 12 out of 12 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| assets/capability/capabilities/vacuumcleaner_job_mode.json | Updates the “job mode changed” flow trigger title translations to “changed to …”. |
| assets/capability/capabilities/thermostat_mode.json | Updates flow trigger/condition/action titles to more explicit “thermostat mode …” phrasing. |
| assets/capability/capabilities/target_power_mode.json | Updates flow trigger/condition/action titles for more consistent phrasing and grammar in several languages. |
| assets/capability/capabilities/swing_mode.json | Updates flow trigger/condition/action titles for consistent “changed to / set to” phrasing. |
| assets/capability/capabilities/refrigerator_mode.json | Makes flow titles more specific by referencing “refrigerator mode” explicitly. |
| assets/capability/capabilities/pump_mode.json | Updates the action title to “Set the pump mode to” (and corresponding translations). |
| assets/capability/capabilities/oven_mode.json | Fixes Danish placeholders and corrects the French !{{...}} template marker usage. |
| assets/capability/capabilities/microwave_mode.json | Fixes German/Italian/Swedish strings for the condition title (template-based “is/is not” phrasing). |
| assets/capability/capabilities/lock_mode.json | Updates flow trigger/condition/action titles to consistent “lock mode … changed/set to” phrasing. |
| assets/capability/capabilities/hot_water_mode.json | Minor English phrasing tweak; fixes Danish condition punctuation/wording and Spanish condition template wording. |
| assets/capability/capabilities/heater_operation_mode.json | Minor English phrasing tweak for the “changed” trigger title. |
| assets/capability/capabilities/fan_mode.json | Fixes duplicated French trigger title text and trims/standardizes wording in a couple of places. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
Hi @wouter-athom, thanks for fixing all these inconsistencies. Can you please consider the following ones if not already handled? #619 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the translations for the enum capabilities are inconsistent. This PR improves some of the translations, making the more in line with each other.