Refactor rest api and manager services in spa#2268
Merged
gxueatlassian merged 4 commits intomainfrom Jul 21, 2023
Merged
Conversation
krazziekay
approved these changes
Jul 21, 2023
| gitHubToken = newToken; | ||
| } | ||
|
|
||
| const hasGitHubToken = () => { |
Collaborator
There was a problem hiding this comment.
/nit
Suggested change
| const hasGitHubToken = () => { | |
| const hasGitHubToken = () => !!gitHubToken |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What's in this PR?
Refactor the rest api.
Why
Right now, due to the location of github token, everything needs to sit within the OAuthManager service, even things like
fetchOrgsunrelated to oauth.I want to split the managers, and this will require the github token stored within the axios instances.
Added feature flags
N/A
Affected issues
Jira Issues
How has this been tested?
Unit test
Local
Whats Next?