refactor(observe): make Arc internal to proc and cgroup caches#593
Merged
dmah42 merged 1 commit intoaurae-runtime:mainfrom Jan 18, 2026
Merged
refactor(observe): make Arc internal to proc and cgroup caches#593dmah42 merged 1 commit intoaurae-runtime:mainfrom
dmah42 merged 1 commit intoaurae-runtime:mainfrom
Conversation
mccormickt
force-pushed
the
push-wswoxxxkzkot
branch
2 times, most recently
from
0e3bf2f to
1ffff8a
Compare
dmah42
previously approved these changes
Jan 18, 2026
Contributor
|
looks great. one test failed though. |
mccormickt
force-pushed
the
push-wswoxxxkzkot
branch
from
1ffff8a to
a98354a
Compare
Contributor
Author
Thanks! Yeah accidentally flipped the order of operations in |
dmah42
approved these changes
Jan 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR moves
Arc's and/orMutex's to be internal toLogChannel,ProcCacheandCgroupCache. This cleans up a lot of instances where we must instantiate wrap the instantiation of the structs in anArc<T>orArc<Mutex<T>>and where we must handle the mutex and locking when accessing the struct's data.