Skip to content

timestamp 0001-01-01 offset #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
cxzl25 wants to merge 1 commit into
base: v0.7.0-auron
Choose a base branch
from
Draft

timestamp 0001-01-01 offset #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
83 changes: 53 additions & 30 deletions src/array_decoder/timestamp.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -264,39 +264,62 @@ impl<T: ArrowTimestampType> ArrayBatchDecoder for TimestampOffsetArrayDecoder<T>
let convert_timezone = |ts| {
// Convert from writer timezone to reader timezone (which we default to UTC)
// TODO: more efficient way of doing this?
if self.has_same_tz_rules {
return Some(ts);
}

let microseconds_in_timeunit = match T::UNIT {
TimeUnit::Second => 1_000_000,
TimeUnit::Millisecond => 1_000,
TimeUnit::Microsecond => 1,
TimeUnit::Nanosecond => -1, // not used in this case
};
// 0001-01-01 00:00:00
const BOUNDARY_MICROS: i64 = -62135798400000000;
const OFFSET_MICROS: i64 = 172457000000;
Copy link
Copy Markdown
Collaborator Author

@cxzl25 cxzl25 Nov 23, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/apache/spark/blob/3c50fda6f29d95c24b664a32ee41c61f0a19eedb/sql/api/src/main/resources/julian-gregorian-rebase-micros.json#L1244


match T::UNIT {
TimeUnit::Second | TimeUnit::Millisecond | TimeUnit::Microsecond => self
.writer_tz
.timestamp_micros(ts * microseconds_in_timeunit)
.single()
.and_then(|dt| {
dt.naive_local()
.and_local_timezone(self.reader_tz)
.single()
.map(|dt_in_reader_tz| {
dt_in_reader_tz.timestamp_micros() / microseconds_in_timeunit
})
}),
TimeUnit::Nanosecond => self
.writer_tz
.timestamp_nanos(ts)
.naive_local()
.and_utc()
.naive_local()
.and_local_timezone(self.reader_tz)
.single()
.and_then(|dt_in_reader_tz| dt_in_reader_tz.timestamp_nanos_opt()),
TimeUnit::Second | TimeUnit::Millisecond | TimeUnit::Microsecond => {
let microseconds_in_timeunit = match T::UNIT {
TimeUnit::Second => 1_000_000,
TimeUnit::Millisecond => 1_000,
TimeUnit::Microsecond => 1,
_ => unreachable!(),
};

if self.has_same_tz_rules {
let timestamp_micros = ts * microseconds_in_timeunit;
let adjusted_micros = if timestamp_micros == BOUNDARY_MICROS {
timestamp_micros + OFFSET_MICROS
} else {
timestamp_micros
};
return Some(adjusted_micros / microseconds_in_timeunit);
}

self.writer_tz
.timestamp_micros(ts * microseconds_in_timeunit)
.single()
.and_then(|dt| {
dt.naive_local()
.and_local_timezone(self.reader_tz)
.single()
.map(|dt_in_reader_tz| {
let timestamp_micros = dt_in_reader_tz.timestamp_micros();
let adjusted_micros = if timestamp_micros == BOUNDARY_MICROS {
timestamp_micros + OFFSET_MICROS
} else {
timestamp_micros
};
adjusted_micros / microseconds_in_timeunit
})
})
}
TimeUnit::Nanosecond => {
if self.has_same_tz_rules {
return Some(ts);
}

self.writer_tz
.timestamp_nanos(ts)
.naive_local()
.and_utc()
.naive_local()
.and_local_timezone(self.reader_tz)
.single()
.and_then(|dt_in_reader_tz| dt_in_reader_tz.timestamp_nanos_opt())
}
}
};
let array = array
Expand Down
Loading
⚡