env ORC_READER_TIMEZONE#9
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adds support for overriding the reader timezone used during ORC timestamp decoding via an environment variable. The change allows users to explicitly set the timezone used for timestamp conversion when reading ORC files with writer timezone information, rather than relying solely on system timezone detection.
Key Changes
- Introduces
AURON_READER_TIMEZONEenvironment variable to override system timezone detection - Falls back to system timezone detection (
iana_time_zone::get_timezone()) when the environment variable is not set - Maintains existing UTC fallback behavior when both environment variable and system detection fail
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| let reader_tz_name = env::var("AURON_READER_TIMEZONE").unwrap_or_else(|e| { | ||
| iana_time_zone::get_timezone().unwrap_or_else(|_| "UTC".to_string()) | ||
| }); |
There was a problem hiding this comment.
The new environment variable AURON_READER_TIMEZONE is not documented. This should be documented in the code (perhaps as a module-level comment or constant) and in the README.md to inform users that they can override the timezone detection behavior. The documentation should explain what values are accepted (IANA timezone names like "America/New_York") and what happens if an invalid value is provided (falls back to system timezone, then UTC).
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
No description provided.