Omit version for request which fixes outdated version with Node 18 is…#168
Open
Poolshark wants to merge 1 commit intoauth0-extensions:masterfrom
Open
Omit version for request which fixes outdated version with Node 18 is…#168Poolshark wants to merge 1 commit intoauth0-extensions:masterfrom
Poolshark wants to merge 1 commit intoauth0-extensions:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✏️ Changes
Since the package version
request@2.56.0does not support Node 18 (which is the recommended version for Auth0 actions),request('request@2.56.0')has been updated withrequest('request')which omits the version completely.🔗 References
This update has also been suggested by the Auth0 helpkdesk:
🎯 Testing
🚫 This change has been tested in a Webtask
🚫 This change has unit test coverage
🚫 This change has integration test coverage
🚫 This change has been tested for performance
🚀 Deployment
I guess omitting the version should work to be backward compatible to Node 16.
✅ This can be deployed any time