Skip to content

Commit 1248c41

Browse files
authored
This reverts commit cf6b196 for reasons outlined in AcademySoftwareFoundation#2301
1 parent b74787d commit 1248c41

7 files changed

Lines changed: 18 additions & 10 deletions

File tree

source/MaterialXRenderGlsl/TextureBaker.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
MATERIALX_NAMESPACE_BEGIN
2020

2121
/// A shared pointer to a TextureBaker
22-
using TextureBakerGlslPtr = shared_ptr<class TextureBakerGlsl>;
22+
using TextureBakerPtr = shared_ptr<class TextureBakerGlsl>;
2323

2424
/// A vector of baked documents with their associated names.
2525
using BakedDocumentVec = std::vector<std::pair<std::string, DocumentPtr>>;
@@ -29,9 +29,9 @@ using BakedDocumentVec = std::vector<std::pair<std::string, DocumentPtr>>;
2929
class MX_RENDERGLSL_API TextureBakerGlsl : public TextureBaker<GlslRenderer, GlslShaderGenerator>
3030
{
3131
public:
32-
static TextureBakerGlslPtr create(unsigned int width = 1024, unsigned int height = 1024, Image::BaseType baseType = Image::BaseType::UINT8)
32+
static TextureBakerPtr create(unsigned int width = 1024, unsigned int height = 1024, Image::BaseType baseType = Image::BaseType::UINT8)
3333
{
34-
return TextureBakerGlslPtr(new TextureBakerGlsl(width, height, baseType));
34+
return TextureBakerPtr(new TextureBakerGlsl(width, height, baseType));
3535
}
3636

3737
TextureBakerGlsl(unsigned int width, unsigned int height, Image::BaseType baseType);

source/MaterialXRenderMsl/TextureBaker.h

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,7 @@
1919
MATERIALX_NAMESPACE_BEGIN
2020

2121
/// A shared pointer to a TextureBakerMsl
22-
using TextureBakerMslPtr = shared_ptr<class TextureBakerMsl>;
22+
using TextureBakerPtr = shared_ptr<class TextureBakerMsl>;
2323

2424
/// A vector of baked documents with their associated names.
2525
using BakedDocumentVec = std::vector<std::pair<std::string, DocumentPtr>>;
@@ -31,9 +31,9 @@ using BakedDocumentVec = std::vector<std::pair<std::string, DocumentPtr>>;
3131
class MX_RENDERMSL_API TextureBakerMsl : public TextureBaker<MslRenderer, MslShaderGenerator>
3232
{
3333
public:
34-
static TextureBakerMslPtr create(unsigned int width = 1024, unsigned int height = 1024, Image::BaseType baseType = Image::BaseType::UINT8)
34+
static TextureBakerPtr create(unsigned int width = 1024, unsigned int height = 1024, Image::BaseType baseType = Image::BaseType::UINT8)
3535
{
36-
return TextureBakerMslPtr(new TextureBakerMsl(width, height, baseType));
36+
return TextureBakerPtr(new TextureBakerMsl(width, height, baseType));
3737
}
3838

3939
protected:

source/MaterialXView/RenderPipeline.h

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,14 @@
1919
#include <MaterialXCore/Value.h>
2020
#include <MaterialXCore/Unit.h>
2121

22+
MATERIALX_NAMESPACE_BEGIN
23+
#ifdef MATERIALXVIEW_METAL_BACKEND
24+
using TextureBakerPtr = shared_ptr<class TextureBakerMsl>;
25+
#else
26+
using TextureBakerPtr = shared_ptr<class TextureBakerGlsl>;
27+
#endif
28+
MATERIALX_NAMESPACE_END
29+
2230
#include <memory>
2331

2432
namespace mx = MaterialX;

source/MaterialXView/RenderPipelineGL.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -492,7 +492,7 @@ void GLRenderPipeline::bakeTextures()
492492
// Construct a texture baker.
493493
mx::Image::BaseType baseType = _viewer->_bakeHdr ? mx::Image::BaseType::FLOAT : mx::Image::BaseType::UINT8;
494494
mx::UnsignedIntPair bakingRes = _viewer->computeBakingResolution(doc);
495-
mx::TextureBakerGlslPtr baker = std::static_pointer_cast<mx::TextureBakerGlsl>(createTextureBaker(bakingRes.first, bakingRes.second, baseType));
495+
mx::TextureBakerPtr baker = std::static_pointer_cast<mx::TextureBakerPtr::element_type>(createTextureBaker(bakingRes.first, bakingRes.second, baseType));
496496
baker->setupUnitSystem(_viewer->_stdLib);
497497
baker->setDistanceUnit(_viewer->_genContext.getOptions().targetDistanceUnit);
498498
baker->setAverageImages(_viewer->_bakeAverage);

source/MaterialXView/RenderPipelineMetal.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -665,7 +665,7 @@
665665
// Construct a texture baker.
666666
mx::Image::BaseType baseType = _viewer->_bakeHdr ? mx::Image::BaseType::FLOAT : mx::Image::BaseType::UINT8;
667667
mx::UnsignedIntPair bakingRes = _viewer->computeBakingResolution(doc);
668-
mx::TextureBakerMslPtr baker = std::static_pointer_cast<mx::TextureBakerMsl>(createTextureBaker(bakingRes.first, bakingRes.second, baseType));
668+
mx::TextureBakerPtr baker = std::static_pointer_cast<mx::TextureBakerPtr::element_type>(createTextureBaker(bakingRes.first, bakingRes.second, baseType));
669669
baker->setupUnitSystem(_viewer->_stdLib);
670670
baker->setDistanceUnit(_viewer->_genContext.getOptions().targetDistanceUnit);
671671
baker->setAverageImages(_viewer->_bakeAverage);

source/PyMaterialX/PyMaterialXRenderGlsl/PyTextureBaker.cpp

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ namespace mx = MaterialX;
1313

1414
void bindPyTextureBaker(py::module& mod)
1515
{
16-
py::class_<mx::TextureBakerGlsl, mx::GlslRenderer, mx::TextureBakerGlslPtr>(mod, "TextureBaker")
16+
py::class_<mx::TextureBakerGlsl, mx::GlslRenderer, mx::TextureBakerPtr>(mod, "TextureBaker")
1717
.def_static("create", &mx::TextureBakerGlsl::create)
1818
.def("setExtension", &mx::TextureBakerGlsl::setExtension)
1919
.def("getExtension", &mx::TextureBakerGlsl::getExtension)

source/PyMaterialX/PyMaterialXRenderMsl/PyTextureBaker.mm

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313

1414
void bindPyTextureBaker(py::module& mod)
1515
{
16-
py::class_<mx::TextureBakerMsl, mx::MslRenderer, mx::TextureBakerMslPtr>(mod, "TextureBaker")
16+
py::class_<mx::TextureBakerMsl, mx::MslRenderer, mx::TextureBakerPtr>(mod, "TextureBaker")
1717
.def_static("create", &mx::TextureBakerMsl::create)
1818
.def("setExtension", &mx::TextureBakerMsl::setExtension)
1919
.def("getExtension", &mx::TextureBakerMsl::getExtension)

0 commit comments

Comments
 (0)