Update Subduction Wasm (for ephemeral message fix)#628
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Bumps @automerge/automerge-subduction to 0.12.1 and fixes a regression in the Subduction ephemeral message bridge where every message after the first from a sender was dropped by the receiver's dedup logic because count was hard-coded to 0. A per-Repo monotonic counter is now used, and a regression test is added.
Changes:
- Replace hard-coded
count: 0inRepo.tsephemeral broadcast with an incrementing#subductionEphemeralCount. - Bump
@automerge/automerge-subductionfrom 0.12.0 to 0.12.1 in root and package manifests + lockfile. - Add regression test for multiple successive ephemeral broadcasts; reformat existing tests (no behavior change).
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/automerge-repo/src/Repo.ts | Replaces hard-coded count: 0 with a per-Repo monotonic counter for outbound ephemeral broadcasts; minor formatting tidy. |
| packages/automerge-repo/package.json | Bumps subduction dep to 0.12.1. |
| package.json | Bumps root subduction dep to 0.12.1. |
| pnpm-lock.yaml | Lockfile updates for 0.12.1. |
| packages/automerge-repo/test/subduction/WebSocket.test.ts | Adds regression test for multiple successive ephemeral broadcasts from one sender. |
| packages/automerge-repo/test/subduction/SaveResilience.test.ts | Pure formatting changes (test bodies unchanged). |
| packages/automerge-repo/test/_repo-perf.test.ts | Pure formatting changes. |
Files not reviewed (1)
- pnpm-lock.yaml: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
5af1fbd to
fc3e360
Compare
alexjg
pushed a commit
that referenced
this pull request
May 18, 2026
alexjg
pushed a commit
that referenced
this pull request
May 18, 2026
alexjg
pushed a commit
that referenced
this pull request
May 18, 2026
alexjg
pushed a commit
that referenced
this pull request
May 19, 2026
This was referenced May 20, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
...also ran the formatter