Skip to content

Update Subduction Wasm (for ephemeral message fix)#628

Merged
expede merged 1 commit into
subductionjsfrom
subductionjs-counter
May 14, 2026
Merged

Update Subduction Wasm (for ephemeral message fix)#628
expede merged 1 commit into
subductionjsfrom
subductionjs-counter

Conversation

@expede

@expede expede commented May 14, 2026

Copy link
Copy Markdown
Member

...also ran the formatter

Copilot AI review requested due to automatic review settings May 14, 2026 07:50

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Bumps @automerge/automerge-subduction to 0.12.1 and fixes a regression in the Subduction ephemeral message bridge where every message after the first from a sender was dropped by the receiver's dedup logic because count was hard-coded to 0. A per-Repo monotonic counter is now used, and a regression test is added.

Changes:

  • Replace hard-coded count: 0 in Repo.ts ephemeral broadcast with an incrementing #subductionEphemeralCount.
  • Bump @automerge/automerge-subduction from 0.12.0 to 0.12.1 in root and package manifests + lockfile.
  • Add regression test for multiple successive ephemeral broadcasts; reformat existing tests (no behavior change).

Reviewed changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/automerge-repo/src/Repo.ts Replaces hard-coded count: 0 with a per-Repo monotonic counter for outbound ephemeral broadcasts; minor formatting tidy.
packages/automerge-repo/package.json Bumps subduction dep to 0.12.1.
package.json Bumps root subduction dep to 0.12.1.
pnpm-lock.yaml Lockfile updates for 0.12.1.
packages/automerge-repo/test/subduction/WebSocket.test.ts Adds regression test for multiple successive ephemeral broadcasts from one sender.
packages/automerge-repo/test/subduction/SaveResilience.test.ts Pure formatting changes (test bodies unchanged).
packages/automerge-repo/test/_repo-perf.test.ts Pure formatting changes.
Files not reviewed (1)
  • pnpm-lock.yaml: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

@expede expede force-pushed the subductionjs-counter branch from 5af1fbd to fc3e360 Compare May 14, 2026 07:58
@expede expede merged commit e8a2c75 into subductionjs May 14, 2026
@expede expede deleted the subductionjs-counter branch May 14, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants