Swift6 mode#199
Closed
heckj wants to merge 4 commits into
Closed
Conversation
…g to not set global vars though...
Collaborator
Author
|
Full resolution will require that a new version of UniFFI is available, with the patch submitted that renders global variables as |
Collaborator
Author
|
Following up on the uniffi-rs repo and release flow, it looks like this will need to wait for the next large-ish release ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HOLD MERGE
Hold the merge until a new version of UniFFI is released to resolve the code generation issue. The PR I submitted to fix the issue we're seeing has been accepted, but further PRs are underway for a more complete UniFFI solution to generating safe Swift6 code.
(We could merge this as is, but then anyone regenerating the code with UniFFI would need to manually update that same
varto alet, which doesn't make sense)Work in progress to enable full compilation for Automerge-swift under Swift 6 language mode.
Most of this is good and ready to go, but there's a manual change I needed to make in
AutomergeUniffi/automerge.swift, which is generated by UniFFI, that needs to be resolved before we can easily make this claim.