Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## v1.x #115 +/- ##
=====================================
Coverage 68% 68%
=====================================
Files 191 191
Lines 17445 17445
=====================================
Hits 11888 11888
Misses 5557 5557 Continue to review full report at Codecov.
|
|
New maintenance of libmemcached makes me irrationally happy! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think nobody should need this for code, as everything should be compatible.
But it may be useful to report which project is used
Example
This may allow to adapt output and avoid user confusion, such as
libmemcached-awesome version => 1.1.0Alternative way may be to change LIBMEMCACHED_VERSION_STRING = "1.1.1 (awesome)", but this may raise issues in some project.