Skip to content

Prevent underflow in memcached_*_response_decrement macros #124

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
m6w6 merged 1 commit into from
Nov 9, 2022
Merged

Prevent underflow in memcached_*_response_decrement macros #124

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions src/libmemcached/common.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,21 @@ static inline void memcached_server_response_increment(memcached_instance_st *in
}
#endif

#define memcached_server_response_decrement(A) (A)->cursor_active_--
#define memcached_server_response_reset(A) (A)->cursor_active_ = 0
#define memcached_server_response_decrement(A) do { \
WATCHPOINT_ASSERT((A)->cursor_active_ > 0); \
if ((A)->cursor_active_ > 0) { \
(A)->cursor_active_--; \
} \
} while (0)
#define memcached_server_response_reset(A) (A)->cursor_active_ = 0

#define memcached_instance_response_increment(A) (A)->cursor_active_++
#define memcached_instance_response_decrement(A) (A)->cursor_active_--
#define memcached_instance_response_decrement(A) do { \
WATCHPOINT_ASSERT((A)->cursor_active_ > 0); \
if ((A)->cursor_active_ > 0) { \
(A)->cursor_active_--; \
} \
} while (0)
#define memcached_instance_response_reset(A) (A)->cursor_active_ = 0

#ifdef __cplusplus
Expand Down
⚡