Enable log config for the metrics agent#1104
Merged
mogren merged 1 commit intoaws:masterfrom Aug 3, 2020
Merged
Conversation
jaypipes
approved these changes
Jul 27, 2020
Contributor
jaypipes
left a comment
jaypipes
left a comment
There was a problem hiding this comment.
++ couple suggestions if you want to address in a future patch.
| } | ||
|
|
||
| func processHistogram(metric *dto.Metric, act *metricsAction) { | ||
| func processHistogram(metric *dto.Metric, act *metricsAction, log logger.Logger) { |
Contributor
There was a problem hiding this comment.
this is fine. might be a bit cleaner, though, to make this function a method on metricsTarget struct versus adding a log parameter to all these functions. :)
Contributor
Author
There was a problem hiding this comment.
I agree, but since metricsTarget is an interface, it will be a somewhat bigger change. Will check in a follow up PR how that would look like. 😄
|
|
||
| func (target *testMetricsTarget) getLogger() logger.Logger { | ||
| return logger.DefaultLogger() | ||
| } |
Contributor
There was a problem hiding this comment.
you wouldn't need this interface method if you just made all those functions instead be methods on metricsTarget.
|
any progress on this pr? |
The cni-metrics-helper should check the same loging config env variables as ipamd does.
mogren
force-pushed
the
fix-metrics-logging
branch
from
1a4334c to
7ee6081
Compare
Contributor
Author
|
@wguto I was out last week, but now I'm back. 🙂 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#1089
Description of changes:
The cni-metrics-helper should check the same logging config env variable as ipamd does to get the log level. Will still log to stdout after this change.
cni-metrics-helperwill get the LogLevel from env variableAWS_VPC_K8S_CNI_LOGLEVELDebuglogFilePathtostdoutin Zap configBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.