Merged
Conversation
mattlandis
reviewed
Jun 25, 2018
Contributor
mattlandis
left a comment
mattlandis
left a comment
There was a problem hiding this comment.
Look pretty good. Just the one comment.
.travis.yml
Outdated
| install: | ||
| - go get -u github.com/golang/dep/cmd/dep | ||
| - go get -u golang.org/x/lint/golint | ||
| - dep ensure |
Contributor
There was a problem hiding this comment.
You should not need to run dep ensure as part of the build. All of the dependencies should be in the vendor directory already and properly versioned. If they are not the build should fail.
Contributor
Author
There was a problem hiding this comment.
You are right! It did fail at first on my mac, but that was because of OS X. Removing the dep stuff.
Contributor
Author
There was a problem hiding this comment.
Passed without dep ensure: https://travis-ci.org/mogren/amazon-vpc-cni-k8s/builds/396655872
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves issue #91
Description of changes:
.gitignore.Tested by enabling Travis CI for my fork: https://travis-ci.org/mogren/amazon-vpc-cni-k8s
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.