Use primary ENI SGs if SG is null for Custom networking#1259
Merged
jayanthvn merged 1 commit intoaws:masterfrom Nov 3, 2020
Merged
Use primary ENI SGs if SG is null for Custom networking#1259jayanthvn merged 1 commit intoaws:masterfrom
jayanthvn merged 1 commit intoaws:masterfrom
Conversation
mogren
reviewed
Oct 12, 2020
mogren
approved these changes
Oct 13, 2020
Contributor
mogren
left a comment
There was a problem hiding this comment.
It needs a rebase, but otherwise it looks good. ![]()
nithu0115
approved these changes
Nov 3, 2020
Contributor
nithu0115
left a comment
There was a problem hiding this comment.
/lgtm. Requesting minor rewording.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug
Which issue does this PR fix:
#1124
What does this PR do / Why do we need it:
If SG is not provided in the ENIConfig then use the primary ENI SGs.
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
Created ENI config -
Before fix SG list is empty-
Terminated the nodes and new nodes after fix -
Automation added to e2e:
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
Upgrades and downgrades should not be impacted. One thing to call out, eni should be deleted and added back for the change to take into effect like terminating the node. Just upgrade will find the existing ENI and re-use it so SG won't be updated.
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.