Make sure calico aws-node gets scheduled on all nodes.#128
Make sure calico aws-node gets scheduled on all nodes.#128liwenwu-amazon merged 2 commits intoaws:masterfrom
Conversation
changed tolerations for calico-node and calico-typha to be sure it gets deployed also to nodes with custom taints like NoExecute and NoSchedule
changed tolerations for aws-node to be sure it gets deployed also to nodes with custom taints like NoExecute and NoSchedule
| path: /var/run/calico | ||
| tolerations: | ||
| # Make sure calico/node gets scheduled on all nodes. | ||
| - effect: NoSchedule |
There was a problem hiding this comment.
@caseydavenport I don't think this is needed for calico policy
There was a problem hiding this comment.
@liwenwu-amazon If the aws CNI is going to tolerate everything, shouldn't the calico policy do the same?
|
LGTM (fwiw) |
|
@dng-dev can you rebase? |
Make sure calico aws-node gets scheduled on all nodes.
|
I was just wondering if this will be pulled into kops? I spent a good amount of time trying to figure out why networking was not coming up correctly on a node group with a taint. Had to manually modify the |
|
And how do I use this with EKS? I spent 2 days figuring out that adding a NoExecute taint on a node killed the networking container. Frustrating. |
|
@cjbottaro , v1.1.0 should fix this. How old is your eks cluster? All EKS clusters created after Jul26 should have v1.1.0. Can you show me the output of |
|
Definitely created before Jul26. Please tell me there is a way to upgrade this besides recreating my EKS cluster... :/ Running that command definitely shows: I guess I can |
changed tolerations for calico-node and calico-typha to be sure it gets deployed also to nodes with custom taints like NoExecute and NoSchedule
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.