Merged
Conversation
- nlb using in tree service controller - clb using in tree service controller - nodeport - clusterIP
jayanthvn
reviewed
Apr 22, 2021
| return err | ||
| } | ||
| observedJob := &v1.Job{} | ||
| return wait.PollImmediateUntil(utils.PollIntervalShort, func() (bool, error) { |
Contributor
There was a problem hiding this comment.
Is there a reason we need to wait for the job to be deleted?
Contributor
Author
There was a problem hiding this comment.
This is to cleanly transition to new test case. For instance once the new test is running the older Job's pod will not be in Running/Terminating state so it will not influence the results of the new test cases.
| deploymentContainer = manifest.NewBusyBoxContainerBuilder(). | ||
| Image("python"). | ||
| Command([]string{"python3"}). | ||
| Args([]string{"-m", "http.server", "80"}).Build() |
Contributor
There was a problem hiding this comment.
What about HTTPS? Are you planning to add it later?
Contributor
Author
There was a problem hiding this comment.
Good point! I have taken up an AI to add HTTPS tests later.
This was referenced Jun 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Integration test
Which issue does this PR fix:
Adds test for verifying connectivity to pods behind service in the following modes
What does this PR do / Why do we need it:
Integration testing
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
NA
Automation added to e2e:
NA
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
NA
Does this change require updates to the CNI daemonset config files to work?:
NA
Does this PR introduce any user-facing change?:
NA
Output
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.