Remove scope: Cluster from spec.names#199
Merged
mogren merged 1 commit intoaws:masterfrom Dec 20, 2018
rickardrosen:patch-1
Merged
Remove scope: Cluster from spec.names#199mogren merged 1 commit intoaws:masterfrom rickardrosen:patch-1
mogren merged 1 commit intoaws:masterfrom
rickardrosen:patch-1
Conversation
This is not a valid configuration
mogren
approved these changes
Dec 20, 2018
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Looks good to me.
Sorry for the delay in reviewing this.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is not a valid configuration
Issue #, if available:
#198 #185
Description of changes:
Remove scope from spec.name
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.