Resolve flakiness in IPAMD warm target tests; update test go.sum#2112
Merged
jayanthvn merged 2 commits intoaws:masterfrom Oct 20, 2022
Merged
Resolve flakiness in IPAMD warm target tests; update test go.sum#2112jayanthvn merged 2 commits intoaws:masterfrom
jayanthvn merged 2 commits intoaws:masterfrom
Conversation
jdn5126
changed the title
jayanthvn
reviewed
Oct 20, 2022
Contributor
jayanthvn
left a comment
jayanthvn
left a comment
There was a problem hiding this comment.
Just a minor comment, rest lgtm.
jayanthvn
approved these changes
Oct 20, 2022
achevuru
approved these changes
Oct 20, 2022
This was referenced Oct 28, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Cleanup
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR resolves flakiness in the IPAMD warm target integration tests. Using ENI values starting at 2 resolves issues from when coredns pods were previously running on node and IPAMD chooses not to prune extra ENI. I also moved global suite variables and functions to the suite file.
This PR also adds missing
go.sumentries following the ginkgo upgrade to v2.3.1. Missing entries were discovered from failing nightly cron job: https://github.com/aws/amazon-vpc-cni-k8s/actions/runs/3278661455/jobs/5397305965If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that cron job steps do not hit this issue anymore.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.