Add retry for plumbing route entry#223
Merged
liwenwu-amazon merged 1 commit intoaws:masterfrom Nov 12, 2018
Merged
Conversation
mogren
reviewed
Nov 8, 2018
| retry, maxRetryRouteAdd) | ||
| time.Sleep(retryRouteAddInterval) | ||
| } else if isRouteExistsError(err) { | ||
| if err := netlink.RouteReplace(&r); err != nil { |
Contributor
There was a problem hiding this comment.
If this replace works, shouldn't we just break the loop and log a success?
liwenwu-amazon
force-pushed
the
bad-route
branch
from
940cae9 to
b7bc3b5
Compare
mogren
reviewed
Nov 9, 2018
| if err := netlink.RouteReplace(&r); err != nil { | ||
| return errors.Wrapf(err, "eni network setup: unable to replace route entry %s", r.Dst.IP.String()) | ||
| } | ||
| break |
Contributor
There was a problem hiding this comment.
Maybe a debug log as well? Something like
log.Debugf("Successfully replaced route to be %s/0", r.Dst.IP.String())
| r.Dst.IP.String(), gw.IP.String(), eniTable) | ||
| } | ||
| } else { | ||
| log.Debugf("Successfully added route route %s/0 via %s table %d", r.Dst.IP.String(), gw.IP.String(), eniTable) |
liwenwu-amazon
force-pushed
the
bad-route
branch
from
b7bc3b5 to
0605376
Compare
mogren
approved these changes
Nov 12, 2018
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Thanks for the fixes, LGTM!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.