Remove go mod download from Dockerfiles#2383
Merged
jdn5126 merged 1 commit intoaws:masterfrom May 17, 2023
Merged
Conversation
orsenthil
approved these changes
May 17, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
N/A
What does this PR do / Why do we need it:
This PR removes the
go mod downloadstep from the init, main, and metrics-helper Dockerfile. The motivation is to speedup initial image build times, which should help in reducing the flakiness of builds in GitHub Actions. Runninggo mod downloadinstalls all go modules in the image builder workspace, including many which are not needed by the image being built. The downside of removing this step is that it removes a caching layer, so subsequent local builds cannot take advantage of the modules downloaded by previous local builds. This tradeoff is considered worth it since all GitHub Actions builds only happen once, and the overhead for local builds is not worth the flakiness or initial wait time.If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
N/A
Testing done on this change:
Manually verified that images can still be built.
Automation added to e2e:
N/A
Will this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades. Has updating a running cluster been tested?:
N/A
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.