Merged
Conversation
jdn5126
suggested changes
Dec 20, 2023
Contributor
jdn5126
left a comment
jdn5126
left a comment
There was a problem hiding this comment.
Thanks for working on this! iptables is a confusing area, so I have a few questions that I hope can make the functions more intuitive for future users
jchen6585
force-pushed
the
iptables-mock
branch
from
2ed77b2 to
ddffd76
Compare
jdn5126
suggested changes
Dec 21, 2023
jchen6585
force-pushed
the
iptables-mock
branch
from
ddffd76 to
6007b05
Compare
jdn5126
reviewed
Dec 21, 2023
jchen6585
force-pushed
the
iptables-mock
branch
2 times, most recently
from
aa1a68b to
2dcc980
Compare
jdn5126
approved these changes
Dec 21, 2023
jdn5126
force-pushed
the
iptables-mock
branch
from
2dcc980 to
b15c616
Compare
jchen6585
force-pushed
the
iptables-mock
branch
from
b15c616 to
6d2392b
Compare
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
enhancement
Which issue does this PR fix:
#2711
What does this PR do / Why do we need it:
Refactors our iptables mock to have more coverage and mimic code behavior (e.g. differentiating append and insert)
If an issue # is not available please add repro steps and logs from IPAMD/CNI showing the issue:
Testing done on this change:
make unit-testWill this PR introduce any new dependencies?:
No
Will this break upgrades or downgrades? Has updating a running cluster been tested?:
No, No
Does this change require updates to the CNI daemonset config files to work?:
No
Does this PR introduce any user-facing change?:
No
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.