Detect if mockgen and goimports are in the path#278
Merged
mogren merged 1 commit intoaws:masterfrom Jan 3, 2019
nak3:commandPathmock
Merged
Detect if mockgen and goimports are in the path#278mogren merged 1 commit intoaws:masterfrom nak3:commandPathmock
mogren merged 1 commit intoaws:masterfrom
nak3:commandPathmock
Conversation
This patch adds validation to detect if `mockgen` and `goimports` are in the executable file path before running commands. Currently, if either `mockgen` or `goimports` does not exists, the program stops, but mock codes are gone.
mogren
approved these changes
Jan 3, 2019
|
|
||
| // TODO detect if mockgen or goimports are in the path | ||
| var ( | ||
| requiredCommands = [2]string{"mockgen", "goimports"} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes:
This patch adds validation to detect if
mockgenandgoimportsarein the executable file path before running commands.
Currently, if either
mockgenorgoimportsdoes not exists, theprogram stops, but mock codes are gone.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.