Feature: ENIConfig set by custom annotation or label names#280
Merged
mogren merged 7 commits intoaws:masterfrom Jan 11, 2019
Merged
Feature: ENIConfig set by custom annotation or label names#280mogren merged 7 commits intoaws:masterfrom
mogren merged 7 commits intoaws:masterfrom
Conversation
mattlandis
reviewed
Jan 8, 2019
dng-dev
suggested changes
Jan 10, 2019
dng-dev
left a comment
dng-dev
left a comment
There was a problem hiding this comment.
Can u provide a more Detailed example. I would prefer a prefix somehow. As example eniConfig-us-east-1a or eniConfig-us-east-1b
dng-dev
approved these changes
Jan 10, 2019
mogren
suggested changes
Jan 10, 2019
mogren
approved these changes
Jan 11, 2019
Contributor
|
Thanks, a lot easier to follow, and thanks @nak3 for the suggestion. 🙂 |
Contributor
|
Thanks for the contribution. /lgtm |
mattlandis
approved these changes
Jan 11, 2019
Contributor
|
@mattlandis @mogren any chance we can get a release that includes this patch? Finding it difficult to start a node that comes up with the annotation set, compared to a label which is supported via kubelet's |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This feature enables user to set custom annotation or label key to define ENIConfig name. One use case if you have nodes in different failure domains. By default AWS deployments set node label failure-domain.beta.kubernetes.io/zone and its value is availability zone name. We can use availability zone name as ENIConfig to map to proper subnets.
Added 2 new environmental variables:
ENI_CONFIG_ANNOTATION_DEF
ENI_CONFIG_LABEL_DEF
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.