Use InClusterConfig when CreateKubeClient() was called without args#293
Merged
mogren merged 1 commit intoaws:masterfrom Jan 21, 2019
nak3:flagerror
Merged
Use InClusterConfig when CreateKubeClient() was called without args#293mogren merged 1 commit intoaws:masterfrom nak3:flagerror
mogren merged 1 commit intoaws:masterfrom
nak3:flagerror
Conversation
When `BuildConfigFromFlags(apiserver, kubeconfig)` was called with empty apiserver and kubeconfig, it fallback to rest.InClusterConfig(). When it happened, amazon-k8s-agent outputs following warning message. ``` ERROR: logging before flag.Parse: W1217 10:37:25.707719 13 client_config.go:533] Neither --kubeconfig nor --master was specified. Using the inClusterConfig. This might not work. ``` Although this error is harmless, it causes some confusion. This patch changes to use `InClusterConfig()` when `BuildConfigFromFlags` was called with empty args. P.S `logging before flag.Parse` is also gone by this patch, as glog is not called.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When
BuildConfigFromFlags(apiserver, kubeconfig)was called withempty apiserver and kubeconfig, it fallbacks to
rest.InClusterConfig(). When it happened, amazon-k8s-agent outputs
following error/warning message.
Although this error is harmless, it causes some confusion.
Hence this patch changes to use
InClusterConfig()whenBuildConfigFromFlagswas called with empty args.P.S
logging before flag.Parseis also solved by this patch, as glogis not called.
Fixes #270
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.