Merged
Conversation
mogren
suggested changes
Mar 13, 2019
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Thanks for opening a PR to fix this issue. I just have a small suggestion.
rudoi
force-pushed
the
rudoi/support-stdout-logging
branch
from
9f99ddb to
95dbe3e
Compare
mogren
approved these changes
Mar 13, 2019
rudoi
added a commit
to newrelic-forks/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 1, 2019
* add support for stdout logging * add log file env var to readme
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Apr 25, 2019
* add support for stdout logging * add log file env var to readme
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#135
Description of changes:
stdoutas an option for log file env varNote: I took the least-friction approach I could think of for adding this. If anyone has a better idea/design for this support, I'd be happy to give it a shot.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.