Adding healthz endpoint to IPamD#548
Merged
mogren merged 1 commit intoaws:release-1.5from Jul 31, 2019
nithu0115:release-1.5
Merged
Adding healthz endpoint to IPamD#548mogren merged 1 commit intoaws:release-1.5from nithu0115:release-1.5
mogren merged 1 commit intoaws:release-1.5from
nithu0115:release-1.5
Conversation
mogren
approved these changes
Jul 30, 2019
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Thanks a lot @nithu0115, the change looks good to me. It follows the standard grpc health check pattern and only does what we need to be able to mark the node as ready.
This was referenced Aug 7, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
#330
Description of changes:
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.