Merged
Conversation
mogren
suggested changes
Oct 3, 2019
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Hi, thanks @Zyqsempai for the PR, but I think it would be better to use something like in this PR: #626
That library also adds jitter. The start delay and max delay is not trivial to set, but I guess we should try to keep the same maximum timeout.
mogren
suggested changes
Oct 4, 2019
Contributor
|
Thanks, looks a lot cleaner, but |
Contributor
Author
|
@mogren Done, thanks for your time. |
mogren
suggested changes
Oct 9, 2019
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Thanks for working on this, just some minor changes left.
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
Zyqsempai
force-pushed
the
347-made-timeouts-exponental
branch
from
b16dc45 to
68571f6
Compare
Contributor
Author
|
@mogren Sorry for delay, I was in vacation, now I a back! PTAL |
Zyqsempai
force-pushed
the
347-made-timeouts-exponental
branch
from
14f29b7 to
68571f6
Compare
Signed-off-by: bpopovschi <zyqsempai@mail.ru>
mogren
approved these changes
Oct 29, 2019
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Thanks @Zyqsempai, nice cleanup!
mogren
pushed a commit
to mogren/amazon-vpc-cni-k8s
that referenced
this pull request
Dec 15, 2019
* Made timeouts exponential using RetryNWithBackoff * Simplified ENI network setup * TestSetupENINetwork Fix Signed-off-by: bpopovschi <zyqsempai@mail.ru>
jaypipes
pushed a commit
that referenced
this pull request
Dec 19, 2019
* Made timeouts exponential using RetryNWithBackoff * Simplified ENI network setup * TestSetupENINetwork Fix Signed-off-by: bpopovschi <zyqsempai@mail.ru>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #347
Made timeouts exponential
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.