Create roles by default for e2e test cluster creation#994
Merged
mogren merged 23 commits intoaws:masterfrom May 27, 2020
Merged
Create roles by default for e2e test cluster creation#994mogren merged 23 commits intoaws:masterfrom
mogren merged 23 commits intoaws:masterfrom
Conversation
…fault test. See if commented tests prevent the large download from occurring (and can we move that download to earlier in the process?
…to test-circle-ci # Conflicts: # scripts/run-integration-tests.sh
mogren
suggested changes
May 27, 2020
Contributor
mogren
left a comment
mogren
left a comment
There was a problem hiding this comment.
Nice! 😄
Two more changes needed:
- Add env variables that we can override
- Squash commits
Create role when spinning up tester. Change to role create in second field. Insert my own arn. Set create for s3 tester bucket. Create s3 bucket empty name. Revert back to role creation. Region changes from CircleCI environment variable, and comment out default test. See if commented tests prevent the large download from occurring (and can we move that download to earlier in the process? Test polling for available pods. Revert polling solution and skip slow conformance tests.
Autogenerate per-region manifests from a common template in order to prevent drift across versions. Also: Separate in-development (unreleased) manifest changes from the most recent release, by creating a `config/master` directory. The idea is that on each new vX.Y release, we: - copy the latest version of config/master to config/vX.Y - set version = `vX.Y` near top of vX.Y/manifests.jsonnet - re-run `make generate` I have confirmed (using a yaml diff tool) that the generated manifests are identical to latest config/v1.6, except for: - re-ordering of documents within the top-level YAML stream - re-ordering of container `env` array - "v1.6.1" docker tag (intentionally) replaced with "latest" (because this is config/master)
Default to testing upgrades to `config/master` manifests in `run-integration-tests.sh`. Follow-on to aws#986. Correct internal comment re starting version: we test upgrades from whatever version is installed by `eks create cluster`. Also: Switch to shell `${foo:=bar}` idiom to reduce duplication (and chance for typos) in `foo=${foo:-bar}`.
Signed-off-by: Gyuho Lee <leegyuho@amazon.com>
mogren
approved these changes
May 27, 2020
Comment on lines
+81
to
+86
| : ${ROLE_CREATE:=true} | ||
| : ${ROLE_ARN:=""} | ||
|
|
||
| # S3 bucket initialization | ||
| : ${S3_BUCKET_CREATE:=true} | ||
| : ${S3_BUCKET_NAME:=""} |
mogren
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#858
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.