fix(amplify-alpha): removing customResponseHeaders property does not remove the headers from the app

[georeeve]

Issue # (if applicable)

Closes #31783.

Reason for this change

After setting the customResponseHeaders property to some value in the App construct, removing it again does not remove the headers in the Amplify console.

Description of changes

I have set the customHeaders property to a default value of an empty string. This sets the relevant CloudFormation property when customResponseHeaders is not provided, therefore overriding any previous values with an empty string. I took a look at a similar issue of removing basic auth from an app and saw we did something similar there - #15243.

Description of how you validated changes

Updated the existing tests with the new default value.

Checklist

• My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

---

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

[aws-cdk-automation]

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.

✅ A exemption request has been requested. Please wait for a maintainer's review.

[georeeve]

Exemption Request - I have updated the existing unit test, and integration test snapshots with the new default values. I'm not really sure what I could put in a new integration test, as it'd test the same values as the existing integration tests.

[gracelu0]

Hi @georeeve , thanks for working on this! For the integration tests, I noticed integ.app.ts and integ.codecommit.ts don't use the integ testing framework - would you be up for refactoring these tests to use the IntegTest construct?

[aws-cdk-automation]

This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

[georeeve]

Hi @gracelu0, sure, I'm happy to do that. I did add a few tests in #31771, so maybe it's worth waiting for that to progress first?

[aws-cdk-automation]

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

[github-actions]

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

[aws-cdk-automation]

AWS CodeBuild CI Report

• CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
• Commit ID: 974030c
• Result: SUCCEEDED
• Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

[Abogical]

Hi @georeeve, Thank you for your contribution!

Currently there are merge conflicts with this PR as snapshots are not sync with the main branch. To resolve this, rebase your changes from main and update the aws-amplify-alpha test snapshots.

[Abogical]

The following integ snapshots still need to be updated:

@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.app-asset-deployment.js
@aws-cdk/aws-amplify-alpha: !!! This test contains destructive changes !!!
@aws-cdk/aws-amplify-alpha:     Stack: cdkamplifyappassetdeploymentcomamazonawscdkcustomresourcesamplifyassetdeploymentprovider02396C99 - Resource: amplifyassetdeploymenthandlerproviderwaiterstatemachineLogGroupC4BDAC97 - Impact: WILL_DESTROY
@aws-cdk/aws-amplify-alpha: !!! If these destructive changes are necessary, please indicate this on the PR !!!
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.app-cache-config.js
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.app-codecommit.js
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.app-compute-role.js
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.app-custom-domain.js
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.branch-compute-role.js
@aws-cdk/aws-amplify-alpha: Failed: /codebuild/output/src65737127/src/actions-runner/_work/aws-cdk/aws-cdk/packages/@aws-cdk/aws-amplify-alpha/test/integ.branch-skew-protection.js

[georeeve]

@Abogical I'm not entirely sure why it's failing that integ test, or even detecting any changes after I've merged in main as I haven't changed it at all. Any ideas?

[Abogical]

@Abogical I'm not entirely sure why it's failing that integ test, or even detecting any changes after I've merged in main as I haven't changed it at all. Any ideas?

@georeeve Try cleaning the repo and rebuilding:

rm packages/@aws-cdk-testing/framework-integ/tsconfig.tsbuildinfo && git clean -f -X **/integ.*.js && npx lerna run build --scope=@aws-cdk-testing/framework-integ

Then rerun and generate the integ test snapshots.

[github-actions]

This PR has not received a response in a while. If you want to keep this issue open, please leave a comment below and auto-close will be canceled.

[georeeve]

Sorry for the delay, I'll try and get this done this week