Skip to content

fix(cognito): custom attributes in userpoolidentityprovider appear without the prefix custom: #32000

Closed
Balaji-JBC wants to merge 2 commits intoaws:mainfrom
Balaji-JBC:fix-26820
Closed

fix(cognito): custom attributes in userpoolidentityprovider appear without the prefix custom: #32000
Balaji-JBC wants to merge 2 commits intoaws:mainfrom
Balaji-JBC:fix-26820

Conversation

@Balaji-JBC
Copy link
Copy Markdown

@Balaji-JBC Balaji-JBC commented Nov 3, 2024

Issue # (if applicable)

Closes #26820 .

Reason for this change

See discussion in mentioned issue.

Description of changes

custom attributes in userpoolidentityproviderbase is modified to be prepended with custom: so that we don't have to explicitly add custom: which is the current workaround. The solution was observed from @diego-santacruz who created this issue

Description of how you validated changes

The existing unit tests has been modified to accommodate the change

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added bug This issue is a bug. effort/small Small work item – less than a day of effort p2 labels Nov 3, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 3, 2024 18:15
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 3, 2024
@Balaji-JBC Balaji-JBC marked this pull request as ready for review November 3, 2024 18:16
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

@Balaji-JBC Balaji-JBC closed this Nov 3, 2024
@Balaji-JBC Balaji-JBC deleted the fix-26820 branch November 3, 2024 20:18
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 3, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 3, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 11780be
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK bug This issue is a bug. effort/small Small work item – less than a day of effort p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

aws-cognito: identity provider attribute mapping mishandles custom attributes

2 participants