fix(aws-ecs-patterns): desiredTaskCount not a property of aws-ecs-patterns #32056#32076
fix(aws-ecs-patterns): desiredTaskCount not a property of aws-ecs-patterns #32056#32076spensireli wants to merge 2 commits intoaws:mainfrom
Conversation
feat: 32056 remove desired task count from ecs patterns
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
Your pull request must be based off of a branch in a personal account (not an organization owned account, and not the main branch). You must also have the setting enabled that allows the CDK team to push changes to your branch (this setting is enabled by default for personal accounts, and cannot be enabled for organization owned accounts). The reason for this is that our automation needs to synchronize your branch with our main after it has been approved, and we cannot do that if we cannot push to your branch. |
|
Comments on closed issues and PRs are hard for our team to see. |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
Issue # (if applicable)
Closes #32056
Reason for this change
desiredTaskCount is deprecated and not a property of the construct in use. Instead use of minCapacity and maxCapacity should be used.
Description of changes
Documentation specified that the user could use "desiredTaskCount " for the ecs-patterns construct. However "desiredTaskCount" is not a property of queueProcessingEc2Service, nor is desiredCount. Instead minCapacity and maxCapacity should be used to specify the count.
Description of how you validated changes
Updated unit tests, ran them, and created a successful build.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license