Skip to content

fix(ecs-patterns): 32056 remove desired task count from ecs patterns#32077

Closed
spensireli wants to merge 2 commits intoaws:mainfrom
spensireli:documentation-fix
Closed

fix(ecs-patterns): 32056 remove desired task count from ecs patterns#32077
spensireli wants to merge 2 commits intoaws:mainfrom
spensireli:documentation-fix

Conversation

@spensireli
Copy link
Copy Markdown

@spensireli spensireli commented Nov 9, 2024

Issue # (if applicable)

Closes #32056.

Reason for this change

desiredTaskCount is deprecated and not a property of the construct in use. Instead use of minCapacity and maxCapacity should be used.

Description of changes

Documentation specified that the user could use "desiredTaskCount " for the ecs-patterns construct. However "desiredTaskCount" is not a property of queueProcessingEc2Service, nor is desiredCount. Instead minCapacity and maxCapacity should be used to specify the count.

Description of how you validated changes

Updated unit tests, ran them, and created a successful build.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Nov 9, 2024
@aws-cdk-automation aws-cdk-automation requested a review from a team November 9, 2024 16:46
@github-actions github-actions bot added effort/small Small work item – less than a day of effort p2 labels Nov 9, 2024
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.

A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.

@spensireli
Copy link
Copy Markdown
Author

Clarification Request

@aws-cdk-automation aws-cdk-automation added the pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run label Nov 9, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: e38d8ee
  • Result: FAILED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week.

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error.

@aws-cdk-automation aws-cdk-automation added the closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. label Dec 9, 2024
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Dec 9, 2024

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 9, 2024
@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

The pull request linter fails with the following errors:

❌ Fixes must contain a change to an integration test file and the resulting snapshot.

PRs must pass status checks before we can provide a meaningful review.

If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing Exemption Request and/or Clarification Request.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK closed-for-staleness This issue was automatically closed because it hadn't received any attention in a while. effort/small Small work item – less than a day of effort p2 pr/reviewer-clarification-requested The contributor has requested clarification on feedback, a failing build, or a failing PR Linter run

Projects

None yet

Development

Successfully merging this pull request may close these issues.

(aws-ecs-patterns): desiredTaskCount not a property of aws-ecs-patterns

2 participants