feat(ec2): Introduce to ec2 prefixlist peer#32084
feat(ec2): Introduce to ec2 prefixlist peer#32084watany-dev wants to merge 5 commits intoaws:mainfrom
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
|
|
||
| // Attach to Security Group | ||
| sg.addIngressRule(prefixList.peer, Port.tcp(80)); | ||
| sg.connections.allowFrom(prefixList.peer, Port.tcp(443)); |
There was a problem hiding this comment.
Can we make PrefixList class directly implement IPeer? Just like security groups:
Then we can write it like: sg.connections.allowFrom(prefixList, Port.tcp(443));
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32084 +/- ##
==========================================
- Coverage 77.30% 77.29% -0.02%
==========================================
Files 114 114
Lines 7627 7627
Branches 1360 1360
==========================================
- Hits 5896 5895 -1
- Misses 1549 1550 +1
Partials 182 182
Flags with carried forward coverage won't be shown. Click here to find out more.
|
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
This PR has been in the CHANGES REQUESTED state for 3 weeks, and looks abandoned. To keep this PR from being closed, please continue work on it. If not, it will automatically be closed in a week. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
Comments on closed issues and PRs are hard for our team to see. |
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
Issue # (if applicable)
None.
Reason for this change
Prefix lists are often used in EC2 ingress and egress configurations, but the current interface is unnecessarily complex.
We will improve this primary use case as follows
Description of changes
Description of how you validated changes
adding unit and integ test.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license