feat(ses): add support to disable account-level suppression list by Tietew · Pull Request #32168 · aws/aws-cdk

Tietew · 2024-11-18T02:34:00Z

Issue # (if applicable)

Closes #32149.

Reason for this change

ConfigurationSet allows us to disable account-level suppression list but CDK missed the configuration.

Description of changes

Introduced disableSuppressionList property to disable account-level suppression list.

Description of how you validated changes

Added unit tests and integ test.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Tietew · 2024-11-18T02:35:34Z

packages/aws-cdk-lib/aws-ses/test/configuration-set.test.ts

+    });
+  });
+
+  test('override suppressionReasons to BOUNCES only', () => {


Tests for suppressionReasons are missing. So I also added.

codecov · 2024-11-18T02:45:07Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 78.48%. Comparing base (bf77e51) to head (2733dc4).

Additional details and impacted files

@@            Coverage Diff             @@
##             main   #32168      +/-   ##
==========================================
- Coverage   78.50%   78.48%   -0.02%     
==========================================
  Files         106      106              
  Lines        7201     7201              
  Branches     1321     1321              
==========================================
- Hits         5653     5652       -1     
- Misses       1361     1362       +1     
  Partials      187      187

Flag	Coverage Δ
suite.unit	`78.48% <ø> (-0.02%)`	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components	Coverage Δ
packages/aws-cdk	`78.48% <ø> (-0.02%)`	⬇️

mazyu36

Thank you for the contribution.
Just one comment.

packages/aws-cdk-lib/aws-ses/README.md

Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

Tietew · 2024-11-27T07:29:16Z

@mazyu36 Thank you so much

mazyu36

Thanks. LGTM

GavinZZ · 2024-12-02T22:26:34Z

Thanks for contributing to CDK!

mergify · 2024-12-02T22:26:52Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Tietew · 2024-12-03T16:26:47Z

@Mergifyio update

mergify · 2024-12-03T16:26:58Z

update

✅ Branch has been successfully updated

mergify · 2024-12-03T16:59:26Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

Tietew · 2024-12-04T08:16:04Z

@Mergifyio refresh

mergify · 2024-12-04T08:16:11Z

refresh

✅ Pull request refreshed

Tietew · 2024-12-04T15:44:08Z

@Mergifyio update

mergify · 2024-12-04T15:44:18Z

update

✅ Branch has been successfully updated

aws-cdk-automation · 2024-12-04T16:15:56Z

AWS CodeBuild CI Report

CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
Commit ID: 7013ac9
Result: SUCCEEDED
Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

mergify · 2024-12-04T16:16:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2024-12-04T19:19:18Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

github-actions bot added the admired-contributor [Pilot] contributed between 13-24 PRs to the CDK label Nov 18, 2024

aws-cdk-automation requested a review from a team November 18, 2024 02:34

github-actions bot added effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 18, 2024

Tietew commented Nov 18, 2024

View reviewed changes

Tietew added 5 commits November 18, 2024 11:54

add support to disable account-level suppression list

7cc51d1

integ test

129b4cd

test explicit disableSuppressionList=false

20e4dfb

readme

f0611c6

Merge branch 'main' into ses-disable-suppression-list

f0dabd3

Tietew force-pushed the ses-disable-suppression-list branch from 8fc61d4 to f0dabd3 Compare November 18, 2024 02:55

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 18, 2024

Merge branch 'main' into ses-disable-suppression-list

09852da

mazyu36 reviewed Nov 25, 2024

View reviewed changes

packages/aws-cdk-lib/aws-ses/README.md Outdated Show resolved Hide resolved

Update packages/aws-cdk-lib/aws-ses/README.md

7f6403a

Co-authored-by: Matsuda <yiyth.fcb6@gmail.com>

mazyu36 approved these changes Nov 27, 2024

View reviewed changes

aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Nov 27, 2024

github-actions bot mentioned this pull request Dec 1, 2024

Monthly PR metrics report #32340

Closed

GavinZZ approved these changes Dec 2, 2024

View reviewed changes

Merge branch 'main' into ses-disable-suppression-list

bef1b8a

aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Dec 2, 2024

Merge branch 'main' into ses-disable-suppression-list

2733dc4

Merge branch 'main' into ses-disable-suppression-list

7013ac9

GavinZZ merged commit bb50c1a into aws:main Dec 4, 2024

github-actions bot locked as resolved and limited conversation to collaborators Dec 4, 2024

Tietew deleted the ses-disable-suppression-list branch December 4, 2024 23:55

Conversation

Tietew commented Nov 18, 2024

Issue # (if applicable)

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

Tietew Nov 18, 2024

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Nov 18, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

mazyu36 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Tietew commented Nov 27, 2024

Uh oh!

mazyu36 left a comment

Choose a reason for hiding this comment

Uh oh!

GavinZZ commented Dec 2, 2024

Uh oh!

mergify bot commented Dec 2, 2024

Uh oh!

Tietew commented Dec 3, 2024

Uh oh!

mergify bot commented Dec 3, 2024

✅ Branch has been successfully updated

Uh oh!

mergify bot commented Dec 3, 2024

Uh oh!

Tietew commented Dec 4, 2024

Uh oh!

mergify bot commented Dec 4, 2024

✅ Pull request refreshed

Uh oh!

Tietew commented Dec 4, 2024

Uh oh!

mergify bot commented Dec 4, 2024

✅ Branch has been successfully updated

Uh oh!

aws-cdk-automation commented Dec 4, 2024

AWS CodeBuild CI Report

Uh oh!

mergify bot commented Dec 4, 2024

Uh oh!

github-actions bot commented Dec 4, 2024

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

codecov bot commented Nov 18, 2024 •

edited

Loading