Skip to content

feat(ecs): support container version consistency#32225

Merged
mergify[bot] merged 3 commits intoaws:mainfrom
isker:version-consistency
Feb 3, 2025
Merged

feat(ecs): support container version consistency#32225
mergify[bot] merged 3 commits intoaws:mainfrom
isker:version-consistency

Conversation

@isker
Copy link
Copy Markdown
Contributor

@isker isker commented Nov 21, 2024

Issue # (if applicable)

Closes #32202.

Reason for this change

Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag.

Description of changes

Add a simple enabled/disabled enum prop to the construct.

More consequentially, default the prop to disabled (instead of unset) if the container image is a CDK asset, for the reasons described in the comments.

Description of how you validated changes

Unit and integration tests.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@aws-cdk-automation aws-cdk-automation requested a review from a team November 21, 2024 05:30
@github-actions github-actions bot added repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 labels Nov 21, 2024
@isker isker force-pushed the version-consistency branch from 63311e2 to f077a3f Compare November 21, 2024 05:40
@codecov
Copy link
Copy Markdown

codecov bot commented Nov 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 80.84%. Comparing base (86ce155) to head (3a2464b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main   #32225   +/-   ##
=======================================
  Coverage   80.84%   80.84%           
=======================================
  Files         236      236           
  Lines       14230    14230           
  Branches     2487     2487           
=======================================
  Hits        11504    11504           
  Misses       2442     2442           
  Partials      284      284           
Flag Coverage Δ
suite.unit 80.84% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
packages/aws-cdk 79.64% <ø> (ø)
packages/aws-cdk-lib/core 82.14% <ø> (ø)

@isker isker force-pushed the version-consistency branch 2 times, most recently from e4d61ca to 1255057 Compare November 22, 2024 04:26
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Nov 22, 2024
@isker isker force-pushed the version-consistency branch from 1255057 to 23808f7 Compare November 22, 2024 05:01
@isker
Copy link
Copy Markdown
Contributor Author

isker commented Nov 25, 2024

@iliapolo I'm not sure why you updated the branch, but it seems that the resulting CodeBuild CI job hanged or something, the GitHub check is stuck in pending.

Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution.
Some comments.

@isker isker force-pushed the version-consistency branch from 719bb27 to b28e007 Compare January 7, 2025 04:23
Support the new ECS::TaskDefinition ContainerDefinition
VersionConsistency property. This is a simple enabled/disabled flag.

Additionally, set a default disabled value if the container image is a
CDK asset, for the reasons described in the comments.
@isker isker force-pushed the version-consistency branch from b28e007 to cb2995a Compare January 7, 2025 04:31
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Jan 7, 2025
@isker isker requested a review from mazyu36 January 7, 2025 05:10
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 7, 2025
Copy link
Copy Markdown
Member

@GavinZZ GavinZZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left one comment to help me understand.

@GavinZZ GavinZZ self-assigned this Jan 31, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Jan 31, 2025
GavinZZ
GavinZZ previously approved these changes Feb 3, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

This pull request has been removed from the queue for the following reason: pull request branch update failed.

The pull request can't be updated

You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it.

If you want to requeue this pull request, you need to post a comment with the text: @mergifyio requeue

@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Feb 3, 2025

@mergify update

@GavinZZ
Copy link
Copy Markdown
Member

GavinZZ commented Feb 3, 2025

@Mergifyio requeue

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

update

❌ Mergify doesn't have permission to update

Details

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/README.md without workflows permission

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

requeue

✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically

@mergify mergify bot dismissed GavinZZ’s stale review February 3, 2025 19:30

Pull request has been modified.

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@aws-cdk-automation
Copy link
Copy Markdown
Collaborator

AWS CodeBuild CI Report

  • CodeBuild project: AutoBuildv2Project1C6BFA3F-wQm2hXv2jqQv
  • Commit ID: 3a2464b
  • Result: SUCCEEDED
  • Build Logs (available for 30 days)

Powered by github-codebuild-logs, available on the AWS Serverless Application Repository

@mergify mergify bot merged commit 37df0d2 into aws:main Feb 3, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Feb 3, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Feb 3, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 3, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

effort/small Small work item – less than a day of effort feature-request A feature should be added or improved. p2 repeat-contributor [Pilot] contributed between 3-5 PRs to the CDK

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ecs: support new versionConsistency on container definitions

4 participants