feat(ecs): support container version consistency#32225
feat(ecs): support container version consistency#32225mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
63311e2 to
f077a3f
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #32225 +/- ##
=======================================
Coverage 80.84% 80.84%
=======================================
Files 236 236
Lines 14230 14230
Branches 2487 2487
=======================================
Hits 11504 11504
Misses 2442 2442
Partials 284 284
Flags with carried forward coverage won't be shown. Click here to find out more.
|
e4d61ca to
1255057
Compare
1255057 to
23808f7
Compare
|
@iliapolo I'm not sure why you updated the branch, but it seems that the resulting CodeBuild CI job hanged or something, the GitHub check is stuck in pending. |
mazyu36
left a comment
There was a problem hiding this comment.
Thank you for the contribution.
Some comments.
...ramework-integ/test/aws-ecs/test/base/integ.task-definition-container-version-consistency.ts
Outdated
Show resolved
Hide resolved
719bb27 to
b28e007
Compare
Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag. Additionally, set a default disabled value if the container image is a CDK asset, for the reasons described in the comments.
b28e007 to
cb2995a
Compare
GavinZZ
left a comment
There was a problem hiding this comment.
Left one comment to help me understand.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated You should look at the reason for the failure and decide if the pull request needs to be fixed or if you want to requeue it. If you want to requeue this pull request, you need to post a comment with the text: |
|
@mergify update |
|
@Mergifyio requeue |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
✅ The queue state of this pull request has been cleaned. It can be re-embarked automatically |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32202.
Reason for this change
Support the new ECS::TaskDefinition ContainerDefinition VersionConsistency property. This is a simple enabled/disabled flag.
Description of changes
Add a simple enabled/disabled enum prop to the construct.
More consequentially, default the prop to disabled (instead of unset) if the container image is a CDK asset, for the reasons described in the comments.
Description of how you validated changes
Unit and integration tests.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license