fix(ecs-patterns): add a feature flag to override default behavior of creating public load balancers (under feature flag)#32276
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
The pull request linter has failed. See the aws-cdk-automation comment below for failure reasons. If you believe this pull request should receive an exemption, please comment and provide a justification.
A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed add Clarification Request to a comment.
f789efe to
bbe0f21
Compare
…or of creating public load balancers If this flag is not set, the default behavior for `ApplicationLoadBalancedFargateService` and `NetworkLoadBalancedFargateService` is to create a public load balancer (not changed). If this flag is set to false, the behavior is that the load balancer will be private by default. This is a feature flag as to keep compatibility with the old behavior. Relevant issue: aws#32274
fca5f83 to
7b7862a
Compare
|
The pull request linter fails with the following errors: PRs must pass status checks before we can provide a meaningful review. If you would like to request an exemption from the status checks or clarification on feedback, please leave a comment on this PR containing |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #32274.
Reason for this change
By default, Fargate services created with
ApplicationLoadBalancedFargateServiceandNetworkLoadBalancedFargateServiceare created with public load balancers with no way to override this default behavior.Description of changes
Adding a new feature flag
@aws-cdk/aws-ecs-patterns:fargateServiceBaseHasPublicLBDefaultthat allows users to create private load balancers by default.If this flag is not set, the default behavior for
ApplicationLoadBalancedFargateServiceandNetworkLoadBalancedFargateServiceis to create a public load balancer (not changed).If this flag is set to false, the behavior is that the load balancer will be private by default.
This is a feature flag as to keep compatibility with the old behavior.
Relevant issue: #32274
Description of how you validated changes
I have added unit tests and they pass.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license