fix(route53): avoid setting unnecessary properties for Recovery Control type Route53 health check#34272
Conversation
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
@Mergifyio update |
✅ Branch has been successfully updated |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
AWS CodeBuild CI Report
Powered by github-codebuild-logs, available on the AWS Serverless Application Repository |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Closes #34262
Reason for this change
Unnecessary properties are set for Route53 health checks for Recovery Control type.
Description of changes
If HealthCheck type is Recovery Control, return
undefinedas default value for three properties (FailureThreshold,RequestInterval, andMeasureLatency).Describe any new or updated permissions being added
N/A
Description of how you validated changes
Used
Match.absent()to validate that the above three properties are not explicitly specified in existing unit tests. And added test cases to the integration testsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license