fix(s3tables): s3 table bucket read access role uses incorrect permission for s3tables:ListNamespaces#35420
Conversation
|
Exemption Request: The existing integration tests covers the granting of read access and asserts which actions should be allowed. I just needed to update the snapshots for the integration tests to the correct action |
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Thank you for the fix! Looks good to me but just one note that when you make a fix the PR title should describe the problem, not the solution. I've updated the title to do so.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
This pull request has been removed from the queue for the following reason: The pull request can't be updated. You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
Pull request has been modified.
|
@Mergifyio update |
❌ Mergify doesn't have permission to updateDetailsFor security reasons, Mergify can't update this pull request. Try updating locally. |
TheRealAmazonKendra
left a comment
There was a problem hiding this comment.
Let's try this again!
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
…ead access.
Reason for this change
When setting up a S3 Table through AWS CDK
@aws-cdk/aws-s3tables-alphaversion 2.214.0-alpha.0 the granting of read access adds the actions3tables:ListNamespace. That action is invalid according to the AWS Console.Description of changes
Switching the invalid action
s3tables:ListNamespaceto the correct one calleds3tables:ListNamespaces. Documentation for the listing of namespaces: https://docs.aws.amazon.com/cli/latest/reference/s3tables/list-namespaces.html.Describe any new or updated permissions being added
None.
Description of how you validated changes
Unit and integration tests passed.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license