chore(cognito): use getResourceNameAttribute() to get UserPoolGroup.groupName#35622
Open
chore(cognito): use getResourceNameAttribute() to get UserPoolGroup.groupName#35622
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Related to #35607.
Reason for this change
follow the established pattern and consistency using
this.getResourceNameAttribute(resource.ref);to get resource name.Description of changes
Fixed the
UserPoolGroup.groupNameproperty to use the established CDK patterngetResourceNameAttribute()instead of directly assigning the CloudFormation resource reference.this.groupName = resource.reftothis.groupName = this.getResourceNameAttribute(resource.ref)in user-pool-group.ts line 127The fix enables developers to use
userPoolGroup.groupNamefor programmatic operations while preserving all existing CloudFormation template generation behavior.Describe any new or updated permissions being added
N/A - No IAM permissions or resource access changes.
Description of how you validated changes
user-pool-group.test.tsthat validate:Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license