Skip to content

fix(elasticache-alpha): cannot import Redis 7 serverless cache#35629

Merged
mergify[bot] merged 6 commits intoaws:mainfrom
mazyu36:fix/import_redis_7
Oct 21, 2025
Merged

fix(elasticache-alpha): cannot import Redis 7 serverless cache#35629
mergify[bot] merged 6 commits intoaws:mainfrom
mazyu36:fix/import_redis_7

Conversation

@mazyu36
Copy link
Copy Markdown
Contributor

@mazyu36 mazyu36 commented Sep 30, 2025

Issue # (if applicable)

N/A

Reason for this change

The ServerlessCache class was missing the CacheEngine.REDIS_7 case in the switch statement that determines the default port for imported caches.

So importing a Redis 7 serverless cache causes an error:

ValidationError: Unsupported cache engine: redis_7

Description of changes

  • Added missing CacheEngine.REDIS_7 case** in the fromServerlessCacheAttributes method's switch statement to ensure Redis 7 caches use the correct default port.
  • Add unit tests for all supported versions.

Describe any new or updated permissions being added

N/A

Description of how you validated changes

Add unit tests

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Sep 30, 2025
@aws-cdk-automation aws-cdk-automation requested a review from a team September 30, 2025 10:37
@github-actions github-actions bot added the distinguished-contributor [Pilot] contributed 50+ PRs to the CDK label Sep 30, 2025
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mazyu36
Copy link
Copy Markdown
Contributor Author

mazyu36 commented Sep 30, 2025

Exemption request: Since no errors occur in unit tests, this is sufficient as a verification of the correction points.

@aws-cdk-automation aws-cdk-automation added the pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. label Sep 30, 2025
@mazyu36 mazyu36 changed the title fix(elasticache): cannot import Redis 7 Serverless Cache fix(elasticache): cannot import Redis 7 serverless cache Oct 3, 2025
@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Oct 3, 2025
@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member and removed pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. labels Oct 14, 2025
@go-to-k
Copy link
Copy Markdown
Contributor

go-to-k commented Oct 14, 2025

Thanks for the nice PR!

@ozelalisen ozelalisen self-assigned this Oct 21, 2025
@ozelalisen ozelalisen changed the title fix(elasticache): cannot import Redis 7 serverless cache fix(elasticache-alpha): cannot import Redis 7 serverless cache Oct 21, 2025
@ozelalisen ozelalisen added pr-linter/exempt-integ-test The PR linter will not require integ test changes and removed pr-linter/exemption-requested The contributor has requested an exemption to the PR Linter feedback. labels Oct 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2025
@aws-cdk-automation aws-cdk-automation dismissed their stale review October 21, 2025 12:01

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@aws-cdk-automation aws-cdk-automation added pr/needs-maintainer-review This PR needs a review from a Core Team Member labels Oct 21, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 21, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 21, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 21, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 2bde1a0 into aws:main Oct 21, 2025
18 of 19 checks passed
@mergify mergify bot removed the queued label Oct 21, 2025
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 21, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

distinguished-contributor [Pilot] contributed 50+ PRs to the CDK p2 pr-linter/exempt-integ-test The PR linter will not require integ test changes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants