Skip to content

ci: add label condition to integration-test-deployment.yml#35708

Merged
mergify[bot] merged 3 commits intomainfrom
deployment-integ-label-condition
Oct 9, 2025
Merged

ci: add label condition to integration-test-deployment.yml#35708
mergify[bot] merged 3 commits intomainfrom
deployment-integ-label-condition

Conversation

@Abogical
Copy link
Copy Markdown
Member

@Abogical Abogical commented Oct 9, 2025

Reason for this change

The new integ test deployment workflow asks for a deployment in the UI. This has been confusing for contributors as it is similarly named to the general integ test available today.

Description of changes

  • Skip this job if the label request-deployment-integ-run
  • Update name of the job to clarify its purpose

Describe any new or updated permissions being added

No new permissions added.

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

Also updates the name of the job to clarify its purpose.
@aws-cdk-automation aws-cdk-automation requested a review from a team October 9, 2025 09:55
@github-actions github-actions bot added p2 admired-contributor [Pilot] contributed between 13-24 PRs to the CDK labels Oct 9, 2025
@mergify mergify bot added the contribution/core This is a PR that came from AWS. label Oct 9, 2025
Copy link
Copy Markdown
Contributor

@kumvprat kumvprat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The workflow is not present anymore in the list of workflows that ran for this PR. Is that expected ? I assumed it will be skipped but would still show up

@aws-cdk-automation aws-cdk-automation added the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2025
@Abogical
Copy link
Copy Markdown
Member Author

Abogical commented Oct 9, 2025

The workflow is not present anymore in the list of workflows that ran for this PR. Is that expected ? I assumed it will be skipped but would still show up

The workflow by default skips PR's if they do not contain snapshot changes. So this is expected.

@abidhasan-aws abidhasan-aws self-requested a review October 9, 2025 15:42
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot added the queued label Oct 9, 2025
@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Oct 9, 2025

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit cff0dcc into main Oct 9, 2025
19 of 20 checks passed
@mergify mergify bot deleted the deployment-integ-label-condition branch October 9, 2025 16:16
@mergify mergify bot removed the queued label Oct 9, 2025
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Oct 9, 2025

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 9, 2025
@aws-cdk-automation aws-cdk-automation removed the pr/needs-maintainer-review This PR needs a review from a Core Team Member label Oct 9, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

admired-contributor [Pilot] contributed between 13-24 PRs to the CDK contribution/core This is a PR that came from AWS. p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants