chore: silence JSII deprecated Node.js version warnings in PR builds#35760
Merged
mergify[bot] merged 1 commit intomainfrom Oct 16, 2025
Merged
chore: silence JSII deprecated Node.js version warnings in PR builds#35760mergify[bot] merged 1 commit intomainfrom
mergify[bot] merged 1 commit intomainfrom
Conversation
aws-cdk-automation
previously requested changes
Oct 16, 2025
mrgrain
changed the title
aws-cdk-automation
dismissed
their stale review
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
rix0rrr
approved these changes
Oct 16, 2025
Contributor
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Contributor
|
Comments on closed issues and PRs are hard for our team to see. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reason for this change
JSII is emitting deprecated Node.js version warnings during PR builds, which creates noise in the build logs and may cause confusion. Suppressing the warnings is okay. We will deal with this upgrade as part of our SOP to deprecate Node 18 support later in the year.
Description of changes
Added
JSII_SILENCE_WARNING_DEPRECATED_NODE_VERSION: trueenvironment variable to both PR build workflows:.github/workflows/codebuild-pr-build.yml.github/workflows/pr-build.ymlThis suppresses the deprecated Node.js version warnings from JSII without affecting functionality.
Describe any new or updated permissions being added
No new permissions required.
Description of how you validated changes
This change only adds an environment variable to silence warnings and doesn't affect build functionality.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license