chore(batch): init base EC2 class for ECS and EKS#35868
chore(batch): init base EC2 class for ECS and EKS#35868mergify[bot] merged 3 commits intoaws:mainfrom
Conversation
abidhasan-aws
left a comment
There was a problem hiding this comment.
Hi @phuhung273 ,
Thanks for the contribution.
I just have a small nit comment.
| readonly instanceTypes: ec2.InstanceType[]; | ||
|
|
||
| /** | ||
| * The instance types that this Compute Environment can launch. |
There was a problem hiding this comment.
I think the this should be instance classes instead of instance types
There was a problem hiding this comment.
Thanks for your review. I've corrected this comment
Signed-off-by: phuhung273 <[email protected]>
Signed-off-by: phuhung273 <[email protected]>
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 7 seconds in the queue, with no time running CI. ReasonThe pull request can't be updated
HintYou should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again. |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Pull request has been modified.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 11 seconds in the queue, including 1 second running CI. Required conditions to merge
|
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Close #35859
Reason for this change
defaultInstanceClasses, useOptimalInstanceClasses, allocationStrategy, spotBidPercentage, instanceRole, launchTemplate, minvCpus, placementGroupand their related functions. I don't want to submit a huge refactor PR directly.Description of changes
Init base EC2 class for ECS and EKS, start with only minimal things:
Description of how you validated changes
Unit + Integ
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license