feat(eks): support MixedInstancePolicy for self-managed nodes#35923
feat(eks): support MixedInstancePolicy for self-managed nodes#35923chancepants wants to merge 15 commits intoaws:mainfrom
Conversation
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
|
|
||||||||||||||||||
|
|
||||||||||||||||||||||
|
This PR has been in the MERGE CONFLICTS state for 3 weeks, and looks abandoned. Note that PRs with failing linting check or builds are not reviewed, please ensure your build is passing To prevent automatic closure:
This PR will automatically close in 14 days if no action is taken. |
|
This PR has been deemed to be abandoned, and will be automatically closed. Please create a new PR for these changes if you think this decision has been made in error. |
|
Comments on closed issues and PRs are hard for our team to see. |
Adds an optional parameter to the cluster addAutoScalingGroupCapacity method to support MixedInstancePolicy. Currently the only alternative is to heavily utilize escape hatches to attach a MixedInstancePolicy to the ASG created within this method.
Issue # (if applicable)
Closes #35732
Reason for this change
Users of eks
cluster.addAutoScalingGroupCapcitydo not have a convenient way to apply a MixedInstancePolicy to their ASG.Description of changes
Added an optional parameter to
cluster.addAutoScalingGroupCapcityto allow users to provide a MixedInstancePolicy which is applied to the ASG.Description of how you validated changes
I added unit tests which largely cover the validation logic and added a unittest to verify CDK deployments succeed with the new parameter.
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license