feat(autoscaling): add instanceLifecyclePolicy support to AutoScalingGroup Property by matoom-nomu · Pull Request #36434 · aws/aws-cdk

matoom-nomu · 2025-12-18T06:49:24Z

Issue # (if applicable)

None

Reason for this change

AWS Auto Scaling groups now support Instance Lifecycle Policy to control instance behavior during lifecycle events.

Description of changes

Add InstanceLifecyclePolicy interface with RetentionTriggers configuration

Describe any new or updated permissions being added

None

Description of how you validated changes

Added unit tests and integ tests

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

github-actions · 2025-12-18T06:51:46Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	48 ran	48 passed

Test	Result
No test annotations available

View Security Guardian Results

github-actions · 2025-12-18T06:51:48Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	48 ran	48 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

…d-instanceLifecyclePolicy

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

gudipati · 2026-02-11T14:21:54Z

packages/aws-cdk-lib/aws-autoscaling/README.md

+You can configure an instance lifecycle policy to control how instances are handled during lifecycle events, particularly when lifecycle hooks are abandoned or fail. This allows fine-grained control over when to preserve instances for manual intervention.
+
+The instance lifecycle policy defines retention triggers that specify when instances should be moved to a Retained state rather than terminated. Retained instances don't count toward desired capacity and remain until you manually terminate them.
+


You can also mention this in the README from docs -

To use instance lifecycle policies in your Auto Scaling group, you must also configure a termination lifecycle hook. If you configure an instance lifecycle policy but don't have any termination lifecycle hooks, the policy has no effect. Instance lifecycle policies will only apply when termination lifecycle actions are abandoned, not when they complete successfully with the CONTINUE result.

Thank you for the review.
I added sentence you mentioned to README.

…d-instanceLifecyclePolicy

gudipati · 2026-02-18T14:39:02Z

...cdk-testing/framework-integ/test/aws-autoscaling/test/integ.asg-instance-lifecycle-policy.ts

+    },
+  },
+});
+


Can we add the termination lifecycle hook in the test as well because it's required ?

// Add termination lifecycle hook - required for instance lifecycle policy to take effect asg.addLifecycleHook('TerminationHook', { lifecycleTransition: autoscaling.LifecycleTransition.INSTANCE_TERMINATING, defaultResult: autoscaling.DefaultResult.ABANDON, heartbeatTimeout: cdk.Duration.seconds(300), });

I added LifecycleHook for each and rerun integ-test,
Thanks for review.

…d-instanceLifecyclePolicy

gudipati

Looks good to me - approving. Could you update your branch with the latest changes from main ?

mergify · 2026-03-18T16:36:39Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-18T16:37:21Z

Merge Queue Status

✅ Entered queue — 2026-03-18 16:36 UTC · Rule: default-squash
🚫 Left the queue — 2026-03-18 17:20 UTC · at 52b94dfe80185abda1d96bf27864a56beb930f86

This pull request spent 43 minutes 45 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

For security reasons, Mergify can't update this pull request. Try updating locally.
GitHub response: refusing to allow a GitHub App to create or update workflow .github/workflows/analytics-metadata-updater.yml without workflows permission

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

aws-cdk-automation

(This review is outdated)

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

…d-instanceLifecyclePolicy

Pull request has been modified.

mergify · 2026-03-24T10:38:19Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-24T10:38:28Z

github-actions · 2026-03-24T10:38:36Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

add instanceLifecyclePolicy support to AutoScalingGroup Property

6e0d4df

aws-cdk-automation requested a review from a team December 18, 2025 06:49

github-actions bot added p2 valued-contributor [Pilot] contributed between 6-12 PRs to the CDK labels Dec 18, 2025

aws-cdk-automation previously requested changes Dec 18, 2025

View reviewed changes

matoom-nomu added 2 commits December 19, 2025 22:45

fix some comments and README

8050168

Merge branch 'main' of https://github.com/matoom-nomu/aws-cdk into ad…

88293bc

…d-instanceLifecyclePolicy

pahud mentioned this pull request Dec 19, 2025

Failed CodeBuild CI - 12 PR(s) pahud/aws-cdk#17

Open

matoom-nomu added 2 commits December 19, 2025 23:09

fix comments

326012a

fix lint error

7d6dea8

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Dec 19, 2025

github-actions bot mentioned this pull request Jan 1, 2026

Monthly PR metrics report #36544

Open

gudipati self-assigned this Feb 11, 2026

gudipati reviewed Feb 12, 2026

View reviewed changes

matoom-nomu added 2 commits February 13, 2026 10:26

Merge branch 'main' of https://github.com/matoom-nomu/aws-cdk into ad…

5747a2b

…d-instanceLifecyclePolicy

fix README

5270ed5

matoom-nomu requested a review from gudipati February 16, 2026 05:12

gudipati reviewed Feb 18, 2026

View reviewed changes

nomu added 2 commits February 24, 2026 14:50

Merge branch 'main' of https://github.com/matoom-nomu/aws-cdk into ad…

e7f83ca

…d-instanceLifecyclePolicy

fix integ-test to use addLifecycleHook

de3c17b

matoom-nomu requested a review from gudipati February 24, 2026 06:28

pahud mentioned this pull request Feb 26, 2026

PRs with Conflicts - 6 PR(s) pahud/aws-cdk#13

Open

resolve conflict

52b94df

gudipati previously approved these changes Mar 18, 2026

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 18, 2026

matoom-nomu temporarily deployed to automation March 24, 2026 08:45 — with GitHub Actions Inactive

aws-cdk-automation previously requested changes Mar 24, 2026

View reviewed changes

matoom-nomu temporarily deployed to automation March 24, 2026 08:56 — with GitHub Actions Inactive

matoom-nomu temporarily deployed to automation March 24, 2026 08:57 — with GitHub Actions Inactive

matoom-nomu force-pushed the add-instanceLifecyclePolicy branch from b2857ad to 52b94df Compare March 24, 2026 09:13

matoom-nomu temporarily deployed to automation March 24, 2026 09:13 — with GitHub Actions Inactive

matoom-nomu temporarily deployed to automation March 24, 2026 09:14 — with GitHub Actions Inactive

matoom-nomu temporarily deployed to automation March 24, 2026 09:15 — with GitHub Actions Inactive

matoom-nomu force-pushed the add-instanceLifecyclePolicy branch from b6dd439 to 52b94df Compare March 24, 2026 09:21

matoom-nomu temporarily deployed to automation March 24, 2026 09:21 — with GitHub Actions Inactive

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 24, 2026

aws-cdk-automation temporarily deployed to automation March 24, 2026 09:23 — with GitHub Actions Inactive

gudipati previously approved these changes Mar 24, 2026

View reviewed changes

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 24, 2026

aws-cdk-automation temporarily deployed to automation March 24, 2026 09:44 — with GitHub Actions Inactive

Merge branch 'main' of https://github.com/matoom-nomu/aws-cdk into ad…

d1b14d5

…d-instanceLifecyclePolicy

matoom-nomu temporarily deployed to automation March 24, 2026 10:06 — with GitHub Actions Inactive

gudipati approved these changes Mar 24, 2026

View reviewed changes

mergify bot merged commit b72ffcc into aws:main Mar 24, 2026
27 of 28 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 24, 2026

		You can configure an instance lifecycle policy to control how instances are handled during lifecycle events, particularly when lifecycle hooks are abandoned or fail. This allows fine-grained control over when to preserve instances for manual intervention.

		The instance lifecycle policy defines retention triggers that specify when instances should be moved to a Retained state rather than terminated. Retained instances don't count toward desired capacity and remain until you manually terminate them.

Conversation

matoom-nomu commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Issue # (if applicable)

Reason for this change

Description of changes

Describe any new or updated permissions being added

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Dec 18, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

gudipati Feb 11, 2026

Choose a reason for hiding this comment

Uh oh!

matoom-nomu Feb 13, 2026

Choose a reason for hiding this comment

Uh oh!

gudipati Feb 18, 2026

Choose a reason for hiding this comment

Uh oh!

matoom-nomu Feb 24, 2026

Choose a reason for hiding this comment

Uh oh!

gudipati left a comment

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 18, 2026

Uh oh!

mergify bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

mergify bot commented Mar 24, 2026

Uh oh!

Uh oh!

mergify bot commented Mar 24, 2026

Merge Queue Status

Uh oh!

github-actions bot commented Mar 24, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

matoom-nomu commented Dec 18, 2025 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

github-actions bot commented Dec 18, 2025 •

edited

Loading

mergify bot commented Mar 18, 2026 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading