feat(eks): add OidcProviderNative using L1 and deprecate OpenIdConnectProvider custom resource#36589
feat(eks): add OidcProviderNative using L1 and deprecate OpenIdConnectProvider custom resource#36589mergify[bot] merged 6 commits intomainfrom
Conversation
|
|
||||||||||||||
|
|
||||||||||||||
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
| /** | ||
| * The thumbprints configured for this provider. | ||
| */ | ||
| public get openIdConnectProviderthumbprints(): string { |
There was a problem hiding this comment.
This thumbprints property is not exposed in the interface IOpenIdConnectProvider which would lead to interface inconsistency.
There was a problem hiding this comment.
I switched from duplicating the props in the interface to match the EKS interface to instead adding oidcProviderNative as a different attribute that matches the new interface while leaving the old one.
I don't think molding the new interface to fit the old one is a good idea as it will create confusion as to why we have duplicate props with different namings and a maintenance burden when moving to cdk v3 as the duplicate props are not deprecated and it doesn't make sense to add something now that is instantly deprecated just to fit the interface.
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status✅ The pull request has been merged at 622be9b This pull request spent 8 hours 30 minutes 4 seconds in the queue, including 7 hours 32 minutes 26 seconds running CI. Required conditions to merge
|
|
➡️ PR build request submitted to A maintainer must now check the pipeline and add the |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Reason for this change
EKS V2 use a custom resource for OpenIdConnectProvider. There is already an L1 for OpenIdConnectProvider, which should be used instead of the custom resource. The L1 construct is needed for migrating from v1 to v2 as custom resources are not importable and recreating the OIDC provider results in a conflict.
Description of changes
BREAKING CHANGE: The
openIdConnectProviderArnandopenIdConnectProviderIssuerproperties have been added as required members of theIOidcProviderinterface.This was the least disruptive change required to allow existing EKS constructs to support the
OidcProviderNativeconstruct.This change is non-breaking for consumers of the interface, but breaking for implementors. If you implement
iam.IOidcProvider, you must now add these two properties, typically as aliases to the existingoidcProviderArnandoidcProviderIssuerproperties.Describe any new or updated permissions being added
None
Description of how you validated changes
Integ tests deployed
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license