feat(s3tables-alpha): add support for partition spec, sort order, and table properties by olenarostotskyy · Pull Request #36811 · aws/aws-cdk

olenarostotskyy · 2026-01-28T22:37:37Z

Reason for this change

This PR adds support for new S3 Tables Iceberg features to the L2 construct library, enabling users to configure partition specifications, sort orders, table properties, and schema field IDs when creating tables.

These features are essential for optimizing query performance and data organization in Iceberg tables.

Description of changes

Enhanced Table construct with new Iceberg metadata properties:

Added id field to SchemaFieldProperty for schema field identification
Added IcebergPartitionSpec and IcebergPartitionField interfaces for partition configuration
Added IcebergSortOrder and IcebergSortField interfaces for sort order configuration
Added tableProperties support for custom Iceberg table properties
Updated IcebergMetadataProperty to include optional icebergPartitionSpec, icebergSortOrder, and tableProperties

Documentation:

Added comprehensive examples for IcebergPartitionField, IcebergPartitionSpec, and IcebergSortOrder
Updated README with "Advanced Iceberg Table Configuration" section showing complete usage examples

Description of how you validated changes

Unit tests: Added comprehensive test coverage for new features (192 tests passing)
Integration test: Created integ.table-with-partition-sort.ts to validate partition spec, sort order, and table properties
Manual testing: Successfully deployed and validated in Gamma environment where the CloudFormation resource type with new properties is available. Verified that partition spec, sort order, and table properties are correctly applied to the Iceberg table metadata.

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

aws-cdk-automation

(This review is outdated)

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

github-actions · 2026-03-03T13:39:46Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	96 ran	96 passed

Test	Result
No test annotations available

View Security Guardian Results

github-actions · 2026-03-03T13:39:48Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	96 ran	96 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

ozelalisen

PR Build is failing, could you make CI/CD working so it is passing?

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts

Pull request has been modified.

ozelalisen

Left some comments regarding design

ozelalisen · 2026-03-04T16:27:30Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

+  /**
+   * The partition transform function (e.g., 'identity', 'day', 'hour', 'bucket', 'truncate').
+   */
+  readonly transform: string;


Could you make this an enum? Is this values are defined, maybe can do?

export enum PartitionTransform { IDENTITY = 'identity', YEAR = 'year', MONTH = 'month', DAY = 'day', HOUR = 'hour', BUCKET = 'bucket', TRUNCATE = 'truncate', }

Updated this to use a PartitionTransform enum.

still using string

could you address this comment? IcebergTransform is an enum-like class so it can be used here instead string

ozelalisen · 2026-03-05T15:54:03Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

+  /**
+   * The sort direction.
+   */
+  readonly direction: 'asc' | 'desc';


better to define this as enum as well:

export enum SortDirection { ASC = 'asc', DESC = 'desc', }

or could we make this just as boolean, if it has only two fields:

readonly ascending: boolean;

Updated this to use a SortDirection enum instead of string literals.
I kept this as an enum rather than a boolean so the API stays explicit and matches the underlying Iceberg/CFN value shape.

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

ozelalisen · 2026-03-05T16:00:14Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

+    // Use addPropertyOverride for properties not yet in L1 types
+    // Override schema to include Id field


Is this still valid, as now L1 resources are published, do you need to still override?

If not please update all overrides below to use L1 values

Removed the overrides.

ozelalisen · 2026-03-05T16:00:49Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table.ts

+  /**
+   * The sort direction.
+   */
+  readonly direction: 'asc' | 'desc';
+
+  /**
+   * The null ordering.
+   */
+  readonly nullOrder: 'nulls-first' | 'nulls-last';


same comments apply here as above

ozelalisen · 2026-03-05T16:05:30Z

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts

+/**
+ * Test for table with partition spec, sort order, and table properties
+ */
+class TableWithPartitionSortStack extends core.Stack {


extending core.Stack is not recommend pattern, use following pattern

import { App, Stack } from 'aws-cdk-lib'; // import this class TestStack extends Stack { // update here } const app = new App(); // Need changes below

Updated this test to use App and Stack from aws-cdk-lib directly.

ozelalisen · 2026-03-05T16:05:39Z

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts

+  }
+}
+
+const app = new core.App();


see above comment

Updated this test to use App and Stack from aws-cdk-lib directly, consistent with the other integration test.

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts

packages/@aws-cdk/aws-s3tables-alpha/README.md

…es, and update docs

… interface property ordering, update transform docs

… ordering, add minimal icebergMetadata example, update integ test bucket name

…t validations

Pull request has been modified.

mergify · 2026-03-19T17:36:05Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-19T17:37:58Z

mergify · 2026-03-19T22:39:13Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

github-actions · 2026-03-19T22:39:28Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

aws-cdk-automation requested a review from a team January 28, 2026 22:37

github-actions bot added p2 beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK labels Jan 28, 2026

aws-cdk-automation previously requested changes Jan 28, 2026

View reviewed changes

olenarostotskyy changed the title ~~Olrostob/s3tables new features~~ Olrostob/s3tables new features #36811 Jan 28, 2026

olenarostotskyy changed the title ~~Olrostob/s3tables new features #36811~~ feat(s3tables-alpha): add support for partition spec, sort order, and table properties Jan 28, 2026

pahud mentioned this pull request Jan 28, 2026

CI Pending Approval - 45 PR(s) pahud/aws-cdk#11

Open

olenarostotskyy commented Jan 28, 2026

View reviewed changes

packages/@aws-cdk/aws-s3tables-alpha/test/integration/integ.table-with-partition-sort.ts Show resolved Hide resolved

olenarostotskyy marked this pull request as ready for review February 12, 2026 07:02

arthi-agrawal mentioned this pull request Feb 14, 2026

S3: Table Buckets support #33054

Open

2 tasks

ozelalisen requested changes Mar 3, 2026

View reviewed changes

ozelalisen self-assigned this Mar 3, 2026

pahud mentioned this pull request Mar 3, 2026

Failed CodeBuild CI - 12 PR(s) pahud/aws-cdk#17

Open

ozelalisen previously requested changes Mar 3, 2026

View reviewed changes

olenarostotskyy force-pushed the olrostob/s3tables-new-features branch from 88c7100 to c7a2825 Compare March 3, 2026 21:32

olenarostotskyy temporarily deployed to automation March 3, 2026 21:33 — with GitHub Actions Inactive

olenarostotskyy temporarily deployed to automation March 3, 2026 22:21 — with GitHub Actions Inactive

olenarostotskyy force-pushed the olrostob/s3tables-new-features branch from 3f304fd to 1948bf0 Compare March 4, 2026 19:03

olenarostotskyy temporarily deployed to automation March 4, 2026 19:03 — with GitHub Actions Inactive

olenarostotskyy temporarily deployed to automation March 4, 2026 19:04 — with GitHub Actions Inactive

ozelalisen previously requested changes Mar 5, 2026

View reviewed changes

olenarostotskyy temporarily deployed to automation March 6, 2026 17:55 — with GitHub Actions Inactive

Olena Rostotskyy added 6 commits March 18, 2026 18:04

fix(s3tables): use enums for partition/sort config, remove L1 overrid…

04093d8

…es, and update docs

fix(s3tables): update integration tests to use App and Stack imports

85e6ebb

fix(s3tables): address PR review comments - simplify integ tests, fix…

93cd1aa

… interface property ordering, update transform docs

fix(s3tables): update README

735bd80

fix: address CR feedback - revert whitespace, fix SchemaFieldProperty…

2da908d

… ordering, add minimal icebergMetadata example, update integ test bucket name

fix: address CR feedback - IcebergTransform class refactor, add inpu…

f0fa696

…t validations

olenarostotskyy force-pushed the olrostob/s3tables-new-features branch from dd5c4db to f0fa696 Compare March 19, 2026 03:29

olenarostotskyy temporarily deployed to automation March 19, 2026 03:29 — with GitHub Actions Inactive

ozelalisen added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Mar 19, 2026

ozelalisen temporarily deployed to deployment-integ-test March 19, 2026 10:07 — with GitHub Actions Inactive

ozelalisen temporarily deployed to automation March 19, 2026 10:07 — with GitHub Actions Inactive

ozelalisen temporarily deployed to automation March 19, 2026 10:08 — with GitHub Actions Inactive

Merge branch 'main' into olrostob/s3tables-new-features

3ea09f0

olenarostotskyy temporarily deployed to automation March 19, 2026 16:14 — with GitHub Actions Inactive

olenarostotskyy had a problem deploying to deployment-integ-test March 19, 2026 16:14 — with GitHub Actions Error

olenarostotskyy temporarily deployed to automation March 19, 2026 16:14 — with GitHub Actions Inactive

ozelalisen removed the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Mar 19, 2026

ozelalisen approved these changes Mar 19, 2026

View reviewed changes

ozelalisen temporarily deployed to automation March 19, 2026 16:51 — with GitHub Actions Inactive

Merge branch 'main' into olrostob/s3tables-new-features

27d9ebc

mergify bot temporarily deployed to automation March 19, 2026 20:11 Inactive

mergify bot merged commit 2696cd1 into aws:main Mar 19, 2026
23 of 24 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 19, 2026

		// Use addPropertyOverride for properties not yet in L1 types
		// Override schema to include Id field

Conversation

olenarostotskyy commented Jan 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

aws-cdk-automation left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 3, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ozelalisen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

ozelalisen left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mergify bot commented Mar 19, 2026

Uh oh!

mergify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify bot commented Mar 19, 2026

Uh oh!

Uh oh!

github-actions bot commented Mar 19, 2026

Uh oh!

Reviewers

Assignees

Labels

olenarostotskyy commented Jan 28, 2026 •

edited

Loading

aws-cdk-automation left a comment •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

github-actions bot commented Mar 3, 2026 •

edited

Loading

mergify bot commented Mar 19, 2026 •

edited

Loading