feat(s3tables): add metrics configuration support for TableBucket by olenarostotskyy · Pull Request #37275 · aws/aws-cdk

olenarostotskyy · 2026-03-17T21:31:21Z

Reason for this change

This PR adds request metrics configuration support to the S3 Tables TableBucket L2 construct, enabling users to enable or disable CloudWatch request metrics for their table buckets.

Request metrics provide insight into Amazon S3 Tables requests, helping users monitor and optimize their table bucket usage.

Description of changes

Enhanced TableBucket construct with request metrics configuration:

Added RequestMetricsStatus enum with ENABLED and DISABLED values
Added requestMetricsStatus property to TableBucketProps (flat structure per CDK guidelines)
Pass metrics configuration through to CfnTableBucket L1 construct

Documentation:

Updated README with "Enabling CloudWatch Request Metrics" section
Added RequestMetricsStatus to rosetta fixture

Description of how you validated changes

Unit tests: added 3 new test cases for request metrics (enabled, disabled, and not specified). All 193 tests passing.
Integration test: created integ.table-bucket-metrics.ts to validate metrics configuration deployment
Rosetta: verified with yarn rosetta:extract - passes successfully

Checklist

My code adheres to the CONTRIBUTING GUIDE and DESIGN GUIDELINES

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

github-actions · 2026-03-18T12:23:08Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results	48 ran	48 passed

Test	Result
No test annotations available

View Security Guardian Results

github-actions · 2026-03-18T12:23:11Z

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.

	Tests	Passed ✅	Skipped	Failed
Security Guardian Results with resolved templates	48 ran	48 passed

Test	Result
No test annotations available

View Security Guardian Results with resolved templates

alvazjor · 2026-03-18T13:35:14Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table-bucket.ts

+   *
+   * @default - Metrics are disabled
+   */
+  readonly metricsConfiguration?: MetricsConfiguration;


The JSDoc here (and in the README too) can be improved by stating that this is a configuration specifically for request metrics and not all S3 table metrics: https://docs.aws.amazon.com/AmazonS3/latest/userguide/s3-tables-cloudwatch-metrics.html
The default looks good

Done. Updated to clarify this is specifically for request metrics:

Renamed enum to RequestMetricsStatus

Renamed prop to requestMetricsStatus

Updated JSDoc and README to say "request metrics"

alvazjor · 2026-03-18T14:03:47Z

packages/@aws-cdk/aws-s3tables-alpha/lib/table-bucket.ts

+   *
+   * @default MetricsConfigurationStatus.DISABLED
+   */
+  readonly status?: MetricsConfigurationStatus;


status is the only property of this interface, and we are marking it optional?
Also, CDK prefers to have flat structures when there is just 1 property, so I think we have 2 options here:

Keep this nested object, make status non optional to have the user to actively choose what they want

Drop this nested object completely, and have the prop flat in the TableBucketProps interface. So something like:

/** * CloudWatch configuration for the request metrics of the table bucket. * * When enabled, S3 Tables publishes CloudWatch request metrics for the table bucket. * * @default - Request metrics are not enabled */ readonly requestMetricsStatus?: MetricsConfigurationStatus;

And when passing them to the L1 resource in line 641, you construct there the CFN shape it needs.

I prefer option 2, seems leaner and more developer friendly, but up to you.

Any option you choose will need an improvement on the JS doc to clrearly mark that the configuration will only be applied to request metrics, and not all metrics

Addressed with Option 2: flattened to requestMetricsStatus?:

RequestMetricsStatus directly on props. Removed the nested interface.

JSDoc updated to clarify this is for request metrics only.

alvazjor · 2026-03-18T14:07:48Z

Also, rosetta is failing the build, something is missing on the config so the README changes can indentify the new types you added and referenced there.

…tus per CR feedback

Pull request has been modified.

mergify · 2026-03-19T19:20:23Z

dequeue

☑️ The pull request is not queued

alvazjor · 2026-03-19T19:21:06Z

@Mergifyio queue

mergify · 2026-03-19T19:21:17Z

mergify · 2026-03-19T20:02:58Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-19T20:03:56Z

Merge Queue Status

✅ Entered queue — 2026-03-19 20:02 UTC · Rule: default-squash
🚫 Left the queue — 2026-03-19 23:24 UTC · at 44847f638920f679c35f55abe2d2bcb06fbea4a7

This pull request spent 3 hours 21 minutes 19 seconds in the queue, with no time running CI.

Reason

The pull request can't be updated

merge conflict between base and head

Hint

You should update or rebase your pull request manually. If you do, this pull request will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue, you can requeue the pull request, without updating it, by posting a @mergifyio queue comment.

alvazjor · 2026-03-20T09:11:33Z

Hi @olenarostotskyy
Seems like there where some changes merged that are generating a conflict on this PR now. Can you please rebase? I will try to merge it again after fixed

…/olenarostotskyy/aws-cdk into olrostob/s3tables-metrics-config

Pull request has been modified.

mergify · 2026-03-20T17:56:12Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

mergify · 2026-03-20T17:56:19Z

mergify · 2026-03-20T18:00:25Z

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

alvazjor · 2026-03-20T18:11:23Z

@Mergifyio queue

mergify · 2026-03-20T18:11:32Z

github-actions · 2026-03-20T18:11:49Z

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

feat(s3tables): add metrics configuration support for TableBucket

e9bbbfa

olenarostotskyy temporarily deployed to automation March 17, 2026 21:31 — with GitHub Actions Inactive

olenarostotskyy temporarily deployed to automation March 17, 2026 21:32 — with GitHub Actions Inactive

github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 17, 2026

aws-cdk-automation requested a review from a team March 17, 2026 21:32

github-actions bot added p2 labels Mar 17, 2026

pahud mentioned this pull request Mar 17, 2026

CI Pending Approval - 45 PR(s) pahud/aws-cdk#11

Open

Merge branch 'main' into olrostob/s3tables-metrics-config

d5fe016

alvazjor temporarily deployed to automation March 18, 2026 12:20 — with GitHub Actions Inactive

alvazjor added the pr/needs-integration-tests-deployment Requires the PR to deploy the integration test snapshots. label Mar 18, 2026

alvazjor temporarily deployed to automation March 18, 2026 12:21 — with GitHub Actions Inactive

alvazjor had a problem deploying to deployment-integ-test March 18, 2026 12:21 — with GitHub Actions Error

alvazjor temporarily deployed to automation March 18, 2026 12:21 — with GitHub Actions Inactive

alvazjor self-assigned this Mar 18, 2026

alvazjor previously requested changes Mar 18, 2026

View reviewed changes

pahud mentioned this pull request Mar 18, 2026

Failed CodeBuild CI - 12 PR(s) pahud/aws-cdk#17

Open

refactor(s3tables): flatten metricsConfiguration to requestMetricsSta…

dd12406

…tus per CR feedback

olenarostotskyy temporarily deployed to automation March 18, 2026 19:56 — with GitHub Actions Inactive

olenarostotskyy had a problem deploying to deployment-integ-test March 18, 2026 19:56 — with GitHub Actions Error

olenarostotskyy temporarily deployed to automation March 18, 2026 19:56 — with GitHub Actions Inactive

Merge branch 'main' into olrostob/s3tables-metrics-config

c740941

olenarostotskyy temporarily deployed to automation March 18, 2026 20:08 — with GitHub Actions Inactive

alvazjor previously approved these changes Mar 19, 2026

View reviewed changes

pahud mentioned this pull request Mar 20, 2026

PRs with Conflicts - 6 PR(s) pahud/aws-cdk#13

Open

Olena Rostotskyy added 2 commits March 20, 2026 10:07

Merge branch 'main' into olrostob/s3tables-metrics-config

a22cee8

Merge branch 'olrostob/s3tables-metrics-config' of https://github.com…

a8214ab

…/olenarostotskyy/aws-cdk into olrostob/s3tables-metrics-config

olenarostotskyy temporarily deployed to automation March 20, 2026 17:09 — with GitHub Actions Inactive

Merge branch 'main' into olrostob/s3tables-metrics-config

30bb8dd

olenarostotskyy temporarily deployed to automation March 20, 2026 17:11 — with GitHub Actions Inactive

olenarostotskyy temporarily deployed to automation March 20, 2026 17:12 — with GitHub Actions Inactive

aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 20, 2026

aws-cdk-automation temporarily deployed to automation March 20, 2026 17:57 — with GitHub Actions Inactive

alvazjor approved these changes Mar 20, 2026

View reviewed changes

mergify bot merged commit e8786f5 into aws:main Mar 20, 2026
38 checks passed

github-actions bot locked as resolved and limited conversation to collaborators Mar 20, 2026

aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 20, 2026

aws-cdk-automation temporarily deployed to automation March 20, 2026 18:13 — with GitHub Actions Inactive

Conversation

olenarostotskyy commented Mar 17, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Reason for this change

Description of changes

Description of how you validated changes

Checklist

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

alvazjor Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olenarostotskyy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

alvazjor Mar 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

olenarostotskyy Mar 18, 2026

Choose a reason for hiding this comment

Uh oh!

alvazjor commented Mar 18, 2026

Uh oh!

mergify bot commented Mar 19, 2026

☑️ The pull request is not queued

Uh oh!

alvazjor commented Mar 19, 2026

Uh oh!

mergify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

mergify bot commented Mar 19, 2026

Uh oh!

mergify bot commented Mar 19, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Reason

Hint

Uh oh!

alvazjor commented Mar 20, 2026

Uh oh!

mergify bot commented Mar 20, 2026

Uh oh!

mergify bot commented Mar 20, 2026

Merge Queue Status

Reason

Hint

Uh oh!

mergify bot commented Mar 20, 2026

Uh oh!

alvazjor commented Mar 20, 2026

Uh oh!

mergify bot commented Mar 20, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Merge Queue Status

Uh oh!

Uh oh!

github-actions bot commented Mar 20, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

olenarostotskyy commented Mar 17, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading

github-actions bot commented Mar 18, 2026 •

edited

Loading

alvazjor Mar 18, 2026 •

edited

Loading

alvazjor Mar 18, 2026 •

edited

Loading

mergify bot commented Mar 19, 2026 •

edited

Loading

mergify bot commented Mar 19, 2026 •

edited

Loading

mergify bot commented Mar 20, 2026 •

edited

Loading