Skip to content

feat(s3tables): implement ITaggableV2 on TableBucket and Table L2 constructs#37277

Merged
mergify[bot] merged 2 commits intoaws:mainfrom
mgarbvs:feat/s3tables-l2-tagging
Mar 26, 2026
Merged

feat(s3tables): implement ITaggableV2 on TableBucket and Table L2 constructs#37277
mergify[bot] merged 2 commits intoaws:mainfrom
mgarbvs:feat/s3tables-l2-tagging

Conversation

@mgarbvs
Copy link
Copy Markdown
Contributor

@mgarbvs mgarbvs commented Mar 17, 2026

Issue # (if applicable)

Related to #33054.

Reason for this change

The L1 constructs (CfnTableBucket, CfnTable) implement ITaggableV2, so Tags.of() already propagates tags to the underlying CloudFormation resources. However, the L2 constructs (TableBucket, Table) don't formally implement ITaggableV2, which means:

  • TagManager.of(tableBucket) returns undefined on the L2 construct
  • The L2 constructs aren't discoverable as taggable by code that checks for ITaggableV2

Description of changes

Implement ITaggableV2 on both TableBucket and Table L2 constructs by delegating cdkTagManager to the underlying L1 resource's tag manager (same pattern as VpcOrigin in aws-cloudfront).

  • TableBucket implements ITaggableV2 with cdkTagManager delegated to CfnTableBucket
  • Table implements ITaggableV2 with cdkTagManager delegated to CfnTable
  • Unit tests for construct-level and stack-level tag propagation (4 new tests)
  • README updated with tagging usage examples
  • Rosetta fixture updated with Tags import

Describe any new or updated permissions being added

N/A

Description of how you validated changes

  1. Built @aws-cdk/aws-s3tables-alpha — 0 errors, 0 warnings
  2. Unit tests — 193 passed (4 new), coverage: 94.46% statements, 90.21% branches
  3. Lint — ESLint + awslint + pkglint clean
  4. Rosetta — README code samples compile
  5. Integration test snapshots — 6/6 UNCHANGED

Checklist


By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license

@github-actions github-actions bot added the p2 label Mar 17, 2026
@aws-cdk-automation aws-cdk-automation requested a review from a team March 17, 2026 23:22
@github-actions github-actions bot added the beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK label Mar 17, 2026
Copy link
Copy Markdown
Collaborator

@aws-cdk-automation aws-cdk-automation left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(This review is outdated)

@mgarbvs mgarbvs force-pushed the feat/s3tables-l2-tagging branch from d38e65a to 0295f8a Compare March 17, 2026 23:36
@aws-cdk-automation aws-cdk-automation dismissed their stale review March 17, 2026 23:38

✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results72 ran72 passed
TestResult
No test annotations available

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 17, 2026

⚠️ Experimental Feature: This security report is currently in experimental phase. Results may include false positives and the rules are being actively refined.
This security report is NOT a review blocker. Please try merge from main to avoid findings unrelated to the PR.


TestsPassed ✅SkippedFailed
Security Guardian Results with resolved templates72 ran72 passed
TestResult
No test annotations available

@aws-cdk-automation aws-cdk-automation added the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 18, 2026
@alvazjor alvazjor self-assigned this Mar 20, 2026
alvazjor
alvazjor previously approved these changes Mar 20, 2026
Copy link
Copy Markdown
Contributor

@alvazjor alvazjor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mgarbvs approving, but this will require rebasing, as there are some conflicts

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 20, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@alvazjor
Copy link
Copy Markdown
Contributor

Hi @mgarbvs, this PR has a merge conflict with main that's blocking the auto-merge. Could you rebase on latest main and resolve the conflicts? Once that's done we should be good to merge. Thanks!

@mergify mergify bot dismissed alvazjor’s stale review March 25, 2026 21:01

Pull request has been modified.

…structs

Add ITaggableV2 support to TableBucket and Table L2 constructs by
delegating cdkTagManager to the underlying L1 resource. This enables
Tags.of() to work directly on L2 constructs and makes them
discoverable as taggable resources.

- TableBucket implements ITaggableV2 with cdkTagManager
- Table implements ITaggableV2 with cdkTagManager
- Add unit tests for construct-level and stack-level tag propagation
- Update README with tagging usage examples
@mgarbvs
Copy link
Copy Markdown
Contributor Author

mgarbvs commented Mar 25, 2026

Solved merge conflicts and rebased!

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2026

Merge Queue Status

  • Entered queue2026-03-26 10:59 UTC · Rule: default-squash
  • Checks passed · in-place
  • Merged2026-03-26 11:32 UTC · at b23ce383fd8f63353fe2dee060e52530bd42c824

This pull request spent 32 minutes 36 seconds in the queue, including 32 minutes 26 seconds running CI.

Required conditions to merge

@mergify
Copy link
Copy Markdown
Contributor

mergify bot commented Mar 26, 2026

Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork).

@mergify mergify bot merged commit 69c8944 into aws:main Mar 26, 2026
23 of 24 checks passed
@github-actions
Copy link
Copy Markdown
Contributor

Comments on closed issues and PRs are hard for our team to see.
If you need help, please open a new issue that references this one.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 26, 2026
@aws-cdk-automation aws-cdk-automation removed the pr/needs-community-review This PR needs a review from a Trusted Community Member or Core Team Member. label Mar 26, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

beginning-contributor [Pilot] contributed between 0-2 PRs to the CDK p2

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants