feat(s3tables): implement ITaggableV2 on TableBucket and Table L2 constructs#37277
feat(s3tables): implement ITaggableV2 on TableBucket and Table L2 constructs#37277mergify[bot] merged 2 commits intoaws:mainfrom
Conversation
d38e65a to
0295f8a
Compare
✅ Updated pull request passes all PRLinter validations. Dismissing previous PRLinter review.
|
|
||||||||||||||
|
|
||||||||||||||
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Hi @mgarbvs, this PR has a merge conflict with main that's blocking the auto-merge. Could you rebase on latest main and resolve the conflicts? Once that's done we should be good to merge. Thanks! |
…structs Add ITaggableV2 support to TableBucket and Table L2 constructs by delegating cdkTagManager to the underlying L1 resource. This enables Tags.of() to work directly on L2 constructs and makes them discoverable as taggable resources. - TableBucket implements ITaggableV2 with cdkTagManager - Table implements ITaggableV2 with cdkTagManager - Add unit tests for construct-level and stack-level tag propagation - Update README with tagging usage examples
984226f to
22dbb9d
Compare
|
Solved merge conflicts and rebased! |
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
Merge Queue Status
This pull request spent 32 minutes 36 seconds in the queue, including 32 minutes 26 seconds running CI. Required conditions to merge
|
|
Thank you for contributing! Your pull request will be updated from main and then merged automatically (do not update manually, and be sure to allow changes to be pushed to your fork). |
|
Comments on closed issues and PRs are hard for our team to see. |
Issue # (if applicable)
Related to #33054.
Reason for this change
The L1 constructs (
CfnTableBucket,CfnTable) implementITaggableV2, soTags.of()already propagates tags to the underlying CloudFormation resources. However, the L2 constructs (TableBucket,Table) don't formally implementITaggableV2, which means:TagManager.of(tableBucket)returnsundefinedon the L2 constructITaggableV2Description of changes
Implement
ITaggableV2on bothTableBucketandTableL2 constructs by delegatingcdkTagManagerto the underlying L1 resource's tag manager (same pattern asVpcOrigininaws-cloudfront).TableBucketimplementsITaggableV2withcdkTagManagerdelegated toCfnTableBucketTableimplementsITaggableV2withcdkTagManagerdelegated toCfnTableTagsimportDescribe any new or updated permissions being added
N/A
Description of how you validated changes
@aws-cdk/aws-s3tables-alpha— 0 errors, 0 warningsChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license